Thread: Simple DList! It should but wont...

if print out list, always returns : List is empty!, even if i put names inside

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <malloc.h>

struct student *dodaj_na_pocetak(struct student *head, char *ime);
void ispis(struct student *head);

struct student{

	char ime[20];
	struct student *next;
};

struct student *head=NULL;
int main()

{
	int sranje;
	char ime[20];
	struct student *nova;
	
	int x;
	while(x!=0){
	printf("\n----Izbornik----");
	printf("\n");
	printf("\n1.Dodaj");
	printf("\n2.Ispis");
	scanf("%d", &x);
	switch(x)
	{
	case 1:
		printf("Upisi ime: ");
		scanf("%s", &ime);
		dodaj_na_pocetak(head,ime);
		break;
	case 2:
		ispis(head);
		break;
		}
	}
		scanf("%d", &sranje);
}

struct student *dodaj_na_pocetak(struct student *head, char *ime){

	struct student *prvi;
	
	prvi = (struct student *)malloc(sizeof(struct student));
	strcpy(prvi->ime,ime);
	prvi->next=head;

	head = prvi;
	return prvi;
}
void ispis(struct student *head){

	struct student *temp;
	temp = head;

		if(temp==NULL)
		{
			printf("Lista je prazna");
			return;
		}
	else
			while(temp!=NULL)
		{
				
			printf("%s", temp->ime);
			printf("\n");
			temp=temp->next;
		}
	}

You are setting "head = prvi", but head is a local variable (argument) in that function, so when you get out of the function, it's still going to be whatever it was before. You need to add another * and do "*head = prvi".

--
Mats

> dodaj_na_pocetak(head,ime);
The function returns a result - don't you think it would be a good idea to do something with it?

> #include <malloc.h>
malloc is declared in stdlib.h, which you include.
This is just a non-portable duplication of effort.

Also, read the FAQ on casting the result of malloc in C programs.

Salem ->

The function returns a result - don't you think it would be a good idea to do something with it?

Thanks man!! So simple....Well it not the first time, I was looking for error for 1h, and look what it was?? it makes you go crazy!
thanks again!