Thread: noob question

you does anyone know what is wrong ith this code

Code:

#include <stdio.h>
#include <stdlib.h>



int fight ( int player_a_p , int enemy_h_p );// a_p means attack points and h_p means health
int main()


{
    int player_a_p;
    int attack_q; // attack_q means attack_question

    
    printf ("You are walking through the woods and a goblin jumps out \n");
    printf ("will you attack [1] or try to escape [2]? \n ");
    scanf ( "%d", &attack_q );
    
    if (attack_q = 1)
    {fight;}
    else
    {printf ("that was not an option!");}
    
}

int fight (int player_a_p , int enemy_h_p , int q_offence );

{
    int player_a_p
    int q_offence
    int enemy_hp;
    enemy_hp = 100;
    
   do   
    
    printf ("enemy hit points : \n " , enemy_h_p);
    printf ("will you use an offensive move [1] \n ");
    scanf ( "d%", &q_offence);
   
    if (q_offence = 1)
   
    {
   
                  player_a_p = randn(10) + 20
                  printf ("you hit for " , player_a_p)
                  printf ("the enemy's hit points are " , enemy_h_p)
                  getchar();
                  getchar();
                  getchar();
                  getchar();
                  getchar();
                  getchar();
    }
    
    while (1==1)
    
    
    
}

im using dev-c++ and this is in c

Code:

-You're not calling fight, you're just referencing it to nothing (has no effect)
-if (q_offence = 1) should be if (q_offence == 1)
-if (attack_q = 1) should be if (attack_q == 1)
-The do-while loop has no {}.
-You havnt added ";" on all your lines.

Some reason i needed to use the code thingies..

Post your new code.

sorry lol

Code:

#include <stdio.h>
#include <stdlib.h>



int fight ( int player_a_p , int enemy_h_p );// a_p means attack points and h_p means health
int main()


{
    int player_a_p;
    int attack_q; // attack_q means attack_question

    
    printf ("You are walking through the woods and a goblin jumps out \n");
    printf ("will you attack [1] or try to escape [2]? \n ");
    scanf ( "%d", &attack_q );
    
    if (1 == attack_q)
    {fight;}
    else
    {printf ("that was not an option!");}
    
}

int fight (int player_a_p , int enemy_h_p , int q_offence );

{
    int player_a_p;
    int q_offence;
    int enemy_hp;
    enemy_hp = 100;
    
   do   
    {
    printf ("enemy hit points : \n " , enemy_h_p);
    printf ("will you use an offensive move [1] \n ");
    scanf ( "d%", &q_offence);
   
    if (1 == q_offence)
   
    {
   
                  player_a_p = randn(10) + 20;
                  printf ("you hit for " , player_a_p);
                  printf ("the enemy's hit points are " , enemy_h_p);
                  getchar();
                  getchar();
                  getchar();
                  getchar();
                  getchar();
                  getchar();
    }
    while (1==1)
    

    
}
    
    
    
    
    ive colon'd up everything exept the stuff im not supposed to (unless im supposed to colon every line)

I wrote this in the other thread - seems like you didn't follow the advice:

Originally Posted by matsp

One tip I have is: When writing conditional code, write it "constant first", because then you don't get into trouble with mixing single equal signs (assign value) with double equal signs (test for equality). E.g.

Code:

  ...
  if ( 7 == magic_number ) ...
  ...

--
Mats

Code:

    if (1 == attack_q)
    {fight;}

This is not calling a function. To call a function, it needs to have parenthesis after the function name. But fight also takes arguments.

Now if we look at this:

Code:

int fight ( int player_a_p , int enemy_h_p );// a_p means attack points and h_p means health
...
int fight (int player_a_p , int enemy_h_p , int q_offence );
...

The first place were fight is declared is called a prototype (it shows what the function looks like, but doesn't have the definition that tells what it actually does).

Next comes teh definition - but it's got a semicolon on the end, so the compiler will think it's a prototype - it will probably complain that you are changing the prototype. After that follows a bunch of code that is the actual fight-code.

So, you need to decide if fight takes two or three arguments, and then pass them, and make the definition of the function work.

I would also advice that you want to put your braces "{" and "}" on separate lines from the code within the braces - making it look nice and tidy is a good goal [and perhaps more important: Constistant - each place of doing something similar should look very similar, so you don't have to think "why does it look different here from the other bit of code that does similar things"].

--
Mats

Originally Posted by gillypie

im sorry matsp i am really a noob i dont understand alot of c jargon yet. but thanks for your help and no-offence - its good advice.

the code you psted does not work on my machine 39ster does it work on yours? just awnted to know if the problems my computer or your code - could be a breakthrough.

Try it again. I just changed

Code:

int fight ();

{

to

Code:

int fight ()

{

AND PLEASE TELL US THE ERROR =D

Code:

while (1==1);

is the same as

Code:

while(1);

--
Mats