I need HELP

Yes that was basically what I needed, I had corrected all the errors that was coming up, but then when I entered in a location, it stopped and went no further. Below is what I had corrected and I believe my problem started right after line 27.

Code:

---

/* Kudler Food Tax Calculator */
//by Deborah Merry
//Calcaulate Sales Tax
//Class: POS370
//Date: July 2007

#include <stdio.h>//header
#include <ctype.h>//isdigit header

main(void)

{
        float        fCost;
        int        iResponse;
       
        fCost=0;
        iResponse=0;


 //Program Header
 printf ("\n\tKudler Fine Foods Sales Tax Calculator\n");
 printf ("\n\tThank you for using the Kudler Tax Calculation Program.\n");
 printf ("\n\tPlease select your location to receive your taxable total.\n");
 printf ("\n 1\tDel Mar\n");
 printf (" 2\tEncinitas\n");
 printf (" 3\tLa Jolla\n");
 printf("\n Please select your location (1-3): ");
 for(;; 1=case 1:)
 if (scanf("%d", &iResponse)==0)
 break;


 puts("Invalid number, please try again");
 
 /* clear the input buffer */
 while((iResponse = getchar()) != '\n' && iResponse != EOF)
 
 switch (iResponse)
{


 case 1:
 printf("\n Welcome Del Mar Associate.\n");
 printf(" Please enter your sub-total: $");
 scanf("\n%f", &fCost);//sale sub-total
 printf(" --------------------------------\n");
 printf(" Your total tax is $%.2f\n", fCost * .0725);//in-line calculation
 printf(" The total amount owed is $%.2f\n", fCost * (1+.0725));//in-line calculation
 break;
 getchar();

 case 2:
 printf("\n Welcome Encinitas associate.\n");
 printf(" Please enter your sub-total: $");
 scanf("%f", &fCost);//sale sub-total
 printf(" --------------------------------\n");
 printf(" Your total tax is $%.2f\n", fCost * .075);//in-line calculation
 printf(" The total amount owed is $%.2f\n", fCost * (1+.075));//in-line calculation
 break;
 getchar();

 case 3:
 printf("\n Welcome La Jolla associate.\n");
 printf(" Please enter your sub-total: $");
 scanf("%f", &fCost);//sale sub-total
 printf(" --------------------------------\n");
 printf(" Your total tax is $%.2f\n", fCost * .0775);//in-line calculation
 printf(" The total amount owed is $%.2f\n", fCost * (1+.0775));//in-line calculation
 break;
 getchar();

}        // end calc

getchar();//keeps application viewable on screen
// end selection

}

---

I started out with taking out all the '}', because I believe that I had too many of those or they were in the wrong places. I actually wanted them to be able to enter another location if they wanted to, but somehow I messed on the coding and lost something along the way.

> for(;; 1=case 1:)
Well this makes no sense at all.

> while((iResponse = getchar()) != '\n' && iResponse != EOF)
This really needs some braces to make it obvious what code you want to loop.

http://cboard.cprogramming.com/showthread.php?t=88495
Have a read of that, then write your program a few lines at a time and make frequent use of the compiler to check your work as you go.

I am actually helping a friend with this one, we have it corrected to ask for another location, but it wil not allow the input of another location, it just ends the program. I am sure that I am missing something within the coding or put brackets where they should not be. Check out my coding below to see what I have come up with.

Code:

---

/*-----------------------------------------------------------------------
//                            PROGRAM INFORMATION
//                        Programmer : J. Kolasa
//
//  Date    : 8-5-2007
//  Name    : SR-kf-008 Tax Calculation- Request 2
//  Filename: main.c
//  Purpose : User selcts store location of choice to calculate purchase total.
//
//---------------------------------------------------------------------*/
#include <stdio.h>
#include <ctype.h>

int main(void)
{
//Declare  and initalize variables
float PurchaseAmount, DelMar, Encinitas, LaJolla;
float DelMarTax, EncinitasTax, LaJollaTax;
float DelMarTotal, EncinitasTotal, LaJollaTotal;
char  AnotherPurchase; //This will initalize user input
int iResponse;
     
PurchaseAmount = 0;
DelMarTax = 0;
EncinitasTax = 0;
LaJollaTax = 0;
DelMarTotal = 0;
EncinitasTotal = 0;
LaJollaTotal = 0;
iResponse = 0 ;
     
//Initialize variables
DelMar = 1.0725;
Encinitas = 1.075;
LaJolla = 1.0775;
DelMarTax = .0725;
EncinitasTax = .075;
LaJollaTax = .0775;

//Program Header
printf("\nWelcome to Kudler Fine Foods");
printf("\nPlease select your store location to receive your taxable total.\n");
printf("\n 1\tDel Mar\n");
printf("\n 2\tEncinitas\n");
printf("\n 3\tLa Jolla\n");
printf("\n Please select a store location (1-3): ");
printf("Choose a number between 1 and 3\n");
                                                             
//Repeatedly get input until a number between 1 and 3 is entered                                   
    while(iResponse <= 0 || iResponse > 3) 
        scanf("&#37;d", &iResponse);
               
if (iResponse == 1)
{                             
           
//Calculate and display sales tax for Del Mar location
printf("\n Welcome to Del Mar.\n");
printf("Please enter your PurchaseAmount: $");
scanf("\n%f", &PurchaseAmount);
printf("-----------------------------------\n");
printf("\n\nThe sales tax for Del Mar location is $%.2f\n", PurchaseAmount*DelMarTax);
//Calculated total for Del Mar location
printf("\nTotal for this sale in DelMar is: $%.2f\n", PurchaseAmount*DelMar);
}
else if (iResponse ==2)
{
//Calculate and display sales tax for Encinitas location
printf("\n Welcome to Encinitas.\n");
printf("Please enter your PurchaseAmount: $");
scanf("\n%f", &PurchaseAmount);
printf("------------------------------------\n");
printf("\n\nThe sales tax for Encinitas location is $%.2f\n", PurchaseAmount*EncinitasTax);
//Calculated total for Encinitas location
printf("\nTotal for this sale in Encinitas is: $%.2f\n", PurchaseAmount*Encinitas);
}
else
{ 
//Calculate and display sales tax for La Jolla location
printf("\n Welcome to La Jolla.\n");
printf("Please enter your PurchaseAmount: $");
scanf("\n%f", &PurchaseAmount);
printf("-----------------------------------\n");
printf("\n\nThe sales tax for La Jolla location is $%.2f\n", PurchaseAmount*LaJollaTax);
//Calculated total for LaJolla location
printf("\nTotal for this sale in La Jolla is: $%.2f\n", PurchaseAmount*LaJolla);
}

//Does user want to enter another purchase.
getchar();
printf("\n\nWould you like to enter another purchase?");
printf("\nPlease resond with 'Y' for yes, or 'N' for no.\n");
scanf ("%c", &AnotherPurchase);

//Ending outputs
printf("\n\n Thank You for shopping at Kudler Fine Foods.\n");
printf("\n\n Have a Nice Day!");
fflush (stdin);
printf("\n Press Enter key to end");
getchar();
}

---

I really appreciate everyone's assistance on this, I thought that I had corrected my problem, but then I also believe that I added something or either left out something that is causing the program not to behave as I had planned.

Put the section of code you want to repeat inside a loop. Then decide what the condition will be. In this case, it's probably that the user has chosen to repeat the code. For example:

Code:

---

int choice = 'y';

while (tolower((char)choice) == 'y')
{
  // ...
  printf("Would you like to continue? y/n: ");
  choice = getchar();
}

---

Ya, maricle C stucks, use Dev, go to www.bloodshed.net to get it, much much much much better, and it has an editor built in.

Also, I am not sure if this will do anything to help at all, but to me it seems to make my code easier to read, and more independent. In your program, after the user chooses 1,2, or 3, you have like 2 if statements, instead of useing else... if.... use 3 if statments. so like this....

Code:

---


if(iResponse == 1)
{
      (Whatever you want)
}

if(iResponse == 2)
{
    (Whatever you want)
}

if(Response == 3)
{
    (Whatever you want)
}

---

While I am no expert, ( didn't even take a class... just read books) I believe this is easier and more clear.. But if you are in a class or something, and your teacher wants it done his/her way, then do it, otherwise I would suggest the way I just showed you.

You didn't end it, maybe that is just because you only gave a bit of code, but you need to put return 0; at the end of the code, or

Code:

---


system("PAUSE");
return 0;

---

But I am not sure I fully understand your problem.

Thank you all for your assistance. I just could not get over the problem of inserting a choice and then it ending. It would not allow me to insert another choice, or if I put in the wrong choice, to give me an error message.

Can any of you help me figure out why my user validity codes aren't working?

The first part needs to only accept inputs 1 - 3 for store location.

The second part needs to ask the user to input only valid numbers. No characters (abc) or signage (-).

Thanks in advance!

Code:

---

#include <stdio.h>

int main(void)
{
    //Declare Variables
    float fsubtotal, taxdelmar, taxencinitas, taxlajolla;
    float fCost;//calculation operator
    int iResponse = 0;
   
    fCost = 0;
    fsubtotal=125.00;
    taxdelmar=.0725;
    taxencinitas=.0750;
    taxlajolla=.0775;

    //Program Header
                printf("\n\tKudler Fine Foods Sales Tax Calculator\n");
            printf("Choose a store: 1 for Del Mar, 2 for Encinitas, and 3 for La Jolla\n");
   
    //Repeatedly get input until a number between 1 and 3 is entered
    while(iResponse <= 0 || iResponse > 3)
        iResponse = scanf("%f", &fsubtotal );
   
    //User Validity
    while (fsubtotal < fCost || iResponse != 1){
        fflush(stdin);
        printf("\n\tPlease Re-enter your Subtotal: $");
        iResponse = scanf("%f", &fsubtotal );
        }//end while loop   
       
   
    if(iResponse ==1)       
    {
            printf("\n Del Mar Store\n");
            printf(" Please enter your sub-total: $");
            scanf("\n%f", &fCost);//sale sub-total
            printf(" --------------------------------\n");
            printf(" Your total tax is $%.2f\n", fCost * .0725);//in-line calculation
            printf(" The total amount owed is $%.2f\n", fCost * (1+.0725));//in-line calculation
    }
    else if(iResponse ==2)       
    {
            printf("\n Encinitas Store\n");
            printf(" Please enter your sub-total: $");
        scanf("%f", &fCost);//sale sub-total
            printf(" --------------------------------\n");
            printf(" Your total tax is $%.2f\n", fCost * .075);//in-line calculation
            printf(" The total amount owed is $%.2f\n", fCost * (1+.075));//in-line calculation
    }
    else
    {       
            printf("\n La Jolla Store\n");
            printf(" Please enter your sub-total: $");
        scanf("%f", &fCost);//sale sub-total
            printf(" --------------------------------\n");
            printf(" Your total tax is $%.2f\n", fCost * .0775);//in-line calculation
            printf(" The total amount owed is $%.2f\n", fCost * (1+.0775));//in-line calculation
               
    }
   
       
            printf("\nPress Enter to end.");
    getchar();//keeps application viewable on screen     
    // end selection
    return 0;
}

---

fflush(stdin); - is undefined behavior - see FAQ

Quote:

---

//Repeatedly get input until a number between 1 and 3 is entered

---

is not what your code is doing,
your asking to enter the float that is >= fCost

the iResponse will be number of entered values, it means 1

so your if/else afterwards has no meaning at all

OK, the whole point of the classroom assignment posted was to teach selection and repetition! Also, a little validation, using if/else was implied.

The assignment is a sales tax calculator, and it prompts the end-user for two pieces of information: purchase amount, and store location, where the store location determines one of three different sales tax amounts. For example,

• 7.25 % sales tax if the store is located in Del Mar
• 7.50 % sales tax if the store is located in Encinitas
• 7.75 % sales tax if the store is located in La Jolla

The sales tax amount for the three locations are constants which do not change, and are not read in from the keyboard or any files.

After the program has read in the two numbers (store number, and sales amount) it should compute the sales tax amount, and show both the tax amount, and the total transaction amount.

Here's a few things that require attention:

1. if you're going to read in integers with 'scanf', the specifier should be either %d or %i
2. There was no reason to mix the following conditions on a while statement: while (fsubtotal < fCost || iResponse != 1)
3. There is no validation, and a simple validation check might have been to ensure negative numbers were not entered for purchase amount; however, checking to make sure the store is 1, 2, or 3 is also validation, and that is present.
4. The end-user is not informed of why a data entry item is incorrect, and why the program requires a retry