Reading File Issue

Do you, by chance, have array overflow? It's about all I can come up with. What this means is that, if you declare an array like this:

ExampleArray[10];

And you try to access ExampleArray[12], this will cause a crash. Check to make sure you don't have this, especially if you have some math in the brackets (like "ExampleArray[(Row*TotalColumns)+Column] = 0;".

The best way that I know of to finding where a crash occurs is to comment out all but one part of your code. If it works without crashing, remove some other area out of the commented out area and try again. If it crashes, you've found the culprit, but leave that area commented out and try the other areas as there could be more than one area. Once all bad areas are isolated, then find out what is going on. I did this quite regularly, and often filling functions with lots of debug-related things and using printf to display what the variable's values are to make sure they are working as expected.

Nah, its defiantly not that. Its assigning variables weird from the file. I know this because when I print the values they were assigned to Im getting weird values.

Heres my cars.dat file where its getting data from.

Code:

---

John Jones 55 250 20
Mary James 67 350 10
Amy Smith 99 100 8
Joe Johns 88 123 86
Trudy Mains 56 1000 80
Mary Ames 97 238 15

---

And heres how its assigning the variables...

Code:

---

for (i=0; i<MAXNUM; i++)
        {
                fscanf(fp, "%s", &fName[i]);          /**/
                fscanf(fp, "%s", &lName[i]);          /**/
                fscanf(fp, "%d", &carNum[i]);        /*Assigns variables from file*/
                fscanf(fp, "%d", &milesDriven[i]);    /**/
                fscanf(fp, "%d", &usedGallons[i]);    /**/
               
        }

---

So the actual file has spaces and numbers as characters in it? Using %d, %c, %s, and %f won't work in that case. I'm not sure how to do it in a reliable way (I can figure out how, but it's highly inefficient). You'd read the number and use either atoi or atof to convert a string into a number. Strings often require the null character in order to work. A space between numbers and words may not work but there's probably a method that allows for it to work. Someone else would have to assist you here.

I can make the data file look however I want, what are fields usually written with? quotes? what are they usually seperated by? commas?

Spaces, tabs, commas, and semicolons are common dividers, at least from what I've seen.

Quote:

---

Originally Posted by ulillillia

Spaces, tabs, commas, and semicolons are common dividers, at least from what I've seen.

---

Well any idea what im doing wrong when declaring variables from that file?

I wouldn't quite know other than than some sort of string parser. That is, it continues to read a string until set characters are encountered and when encountered, various functions are applied such as displaying the names first, then using atoi and atof to convert strings into numbers.

> char *fName[MAXNUM]
If you want an array of strings.

Code:

---

char fName[MAXNUM][MAXLEN];
...
fscanf(fp, "%s", fName[i]);
...
printf("%", fName[i]);

---

Quote:

---

Originally Posted by Salem

> char *fName[MAXNUM]
If you want an array of strings.

Code:

---

char fName[MAXNUM][MAXLEN];
...
fscanf(fp, "%s", fName[i]);
...
printf("%", fName[i]);

---

---

If I could hug you right now, I would. Thank you so much, was starting to feel hopeless.