Thread: Program crashes, why?

I'm writing a program to read in user intered values for a country (read into a 2D character array) and 2 different types of values (into a 2D float array) and calculate a third value. I wrote out my code and it compiles fine and whatnot, but when I run it, it crashes after the first entered float value.

Code:

#include <stdio.h>
#include <ctype.h>
#include <string.h>
#define NCHARS 15
#define NCOLS 3
#define MAXCOUNTRY 10

int collectdata(char country[][NCHARS], float stats[][NCOLS]);
void printdata(char country[][NCHARS], float stats[][NCOLS], int count);
void printheader();

int main()
{
	int count;
	float stats[MAXCOUNTRY][NCOLS];
	char country[MAXCOUNTRY][NCHARS];
	
	count = collectdata(country, stats);
	printdata(country, stats, count);
	
	return 0;
	
}

int collectdata(char country[MAXCOUNTRY][NCHARS], float stats[MAXCOUNTRY][NCOLS])
{
	char ans;
	int count=0;
	
	ans = 'Y';
	
	while (ans != 'N' && toupper(ans) != 'N')
	{
		printf("Enter the name of the country:");
		gets(country[count]);
		printf("Enter the number of units:");
		scanf("%f", stats[count][0]);
		printf("Enter the MWe:");
		scanf("%f", stats[count][1]);
		
		stats[count][2] = (stats[count][1])/(stats[count][0]);
		
		printf("\nDo you want to enter another country? (Y or N)");
		scanf(" %c", ans);
		count++;
	}
	
	return count;
}

void printdata(char country[MAXCOUNTRY][NCHARS], float stats[MAXCOUNTRY][NCOLS], int count)
{
	int i;
	
	printheader();
	
	for (i=0; i<count; i++)
	{
			printf("%s %4f %4f %4f", country[i], stats[i][0], stats[i][1], stats[i][2]);
	}
	
	
}

void printheader()
{
	printf("World Nuclear Power Generation \n");
	printf("      As of January 2007       \n");
	printf("Country     Units  Total  MWe  \n");
}

so I'm assuming its something wrong with the collectdata function, but I can't figure it out - anyone wanna give me any tips/point it out for me?

Originally Posted by Mahdi123

Code:

scanf("%f", stats[count][0]);

Should be:

Code:

scanf("%f", &stats[count][0]);

And the same problem here:

Code:

scanf(" %c", &ans);

Also, you use gets(), which is bad, but forgivable. Check the FAQ, switch to fgets().

Breakpoint 1, main () at try.c:18
18 count = collectdata(country, stats);
(gdb) next
Enter the name of the country:hello
Enter the number of units:3

Program received signal SIGSEGV, Segmentation fault.
0xff2a9818 in __inrange_single () from /usr/lib/libc.so.1
(gdb) where
#0 0xff2a9818 in __inrange_single () from /usr/lib/libc.so.1
#1 0xff2aa384 in decimal_to_single () from /usr/lib/libc.so.1
#2 0xff3102c4 in number () from /usr/lib/libc.so.1
#3 0xff30ffc4 in __doscan_u () from /usr/lib/libc.so.1
#4 0xff30f6a0 in _doscan () from /usr/lib/libc.so.1
#5 0xff315804 in vscanf () from /usr/lib/libc.so.1
#6 0xff3145fc in scanf () from /usr/lib/libc.so.1
#7 0x000107e4 in collectdata (country=0xffbffc20, stats=0xffbffcb8)
at try.c:37
#8 0x000106cc in main () at try.c:18
(gdb)

ahhh ok thanks, I knew it would be something stupid like that I would forget.

Also, gets() is just what they told me to use in class, but I shall promptly inform myself otherwise.

Originally Posted by Mahdi123

Also, gets() is just what they told me to use in class, but I shall promptly inform myself otherwise.

Excellent. It's not your fault, by the way. If an instructor tells you to use something, you're not going to second guess him. The problem is that people who should know better, are telling students that they should use gets(). These people need at least a stern talking to, more preferably a couple of slaps with a two-by-four.