linked list program

[dlcp]

well.. this is the starting of my project of C introduction..
and i wanna know if there is some problem with the code.. and how can it be optimized or sumthing..
thanks

[IsmAvatar2]

line 12, usually I like to approach this by using a pointer rather than a student, but it's up to you. Also, usually I like to use a void pointer, since then you can store anything in the linked list.
line 28, 59, and 67, you don't need to cast malloc.
line 57 and 60, consider a different variable name from new since that is a C++ keyword. Obviously it doesn't really matter until you randomly decide to use a c++ compiler, but it's just nice to avoid.
line 60 and 61, correct me if I'm wrong, but can't you use curr->data and curr->next instead of having to dereference it? Also look at 69, 71, 82, 83, 97 (2x), and 98


Everything I say are only suggestions and do not need to be followed by any means.

[Salem]

The code, so you don't have to download it just to see.

#include <stdio.h>
#include <stdlib.h>

struct student
	{
	char name[15];
	char surname[15];
	};

struct node
	{
	struct student data;
	struct node* next;
	};


struct node* head=NULL;
struct node* curr;
void output();
void input();
void append();
void save();

int main(void)
{	
	int option;
	FILE *fl;
	struct student* temp = (struct student*)malloc(sizeof(struct student));

	fl = fopen("agenda.dat","rb");
	if (fl != NULL)
		while(fread(temp,sizeof(struct student),1,fl)!=(size_t)NULL)
			{
			append(temp);
			}

	do 
		{
		//system("cls");															//Windows Only...
		printf("Menu\n1: Add\n2: View\n3: Save\n0: Exit\n\nOption: ");
		scanf("%d",&option);
		if(option==1)
			input();
		else if(option==2)
			output();
		else if(option==3)
			save();
			
		}
	while(option);
	if (head != NULL)
		save();
	
	
	return(0);
}
void append(struct student* new)
	{
	curr = (struct node*)malloc(sizeof(struct node));
	(*curr).data = *new;
	(*curr).next = head;
	head = curr;
	}

void input(void)
	{
	struct student* temp = (struct student*)malloc(sizeof(struct student));
	printf("Name: ");
	scanf("%s",(*temp).name);
	printf("Surname: ");
	scanf("%s",(*temp).surname);
	append(temp);
	free(temp);
	}

void output()
	{
	curr = head;
	if (head!=NULL)
		while(curr)
			{
			printf("\nName: %s\n",(*curr).data.name);
			printf("Surname: %s\n",(*curr).data.surname);
			curr=(*curr).next;
			}
	else
		printf("Noobs\n");
	}

void save()
	{
	FILE *fl;
	fl = fopen("agenda.dat","wb");
	curr = head;
	while(curr)
		{
		fwrite(&(*curr).data, sizeof((*curr).data), 1 , fl );
		curr=(*curr).next;
		}
	fclose(fl);
	}

[dlcp]

there is some diference betwen (*ptr).data and ptr->data?

[itsme86]

there is some diference betwen (*ptr).data and ptr->data?

No. They're exactly the same. However, the latter is much more commonly used.