Thread: strcmp on a linked list to a string n

I have a problem working this one out for strings... this small function should return a pointer to fred for example if fred were in the list or NULL otherwise, a simple find operation. The output always returns the same pointer no matter how I've tried different things.

In short, is the logic of this method sound? Can anyone spot the problem? The correct header files are called and it compiles but just doesn't output the correct pointer ---> given a string n and a pointer to the list as parameters. The linked list has only 2 parts to the struct - data_item and next.

Code:

node_ptr find(char *n, node_ptr list)
{
	node_ptr located = list->next;
	
	while(located != NULL && (!strcmp(located->data_item, n) == 0));
	{
		located = located->next;
	}

	return located;
}

sorry salem that ; shouldn't be there...

without the ; ...

I've noticed another issue with a previously working method not working at all so the problem may be elsewhere... does the find method look logical to you at this point? I am beginning to think my issue is somewhere else.

any advice would be welcome

no, I realised n had no string being passed in... but unfortunately its still returning the exact same pointer no matter what - it returns NULL if its not in there but otherwise it returns the same pointer every time...

no i have found the issue is in main... I'll work on it tomorrow and try to see what happened. I have a bit of junk code that compiled - thanks for looking at it though, greatly appreciated.