Thread: having trouble with searching an array..

My problem involves writing a function that takes an integer array and an index as arguements, and returns the value of the integer in the array that appears most frequently, only that if there are 2 or more values with the same frequency, the smallest should be returned.

I have been able to get this far:

Code:

void find_maxfreq(int A[], int index) {
	int i=0, j=0, maxfreq=1, freq=1, number=0;
	int numbers[MAXVALS];

	for (i=0 ; i<index; i++) {
		for (j=i+1; j<index; j++) {
			if (A[i]==A[j]) {
				freq++;
			}
		}
		if (freq>=maxfreq) {
			maxfreq = freq;
			number = A[i];
			freq = 1;			
		}
	}
		printf("Max freq : %d\n", maxfreq);
		printf("Value : %d\n", number);
	return;
}

this works great, but does not work for the last condition for the return of the smallest value when there are similar frequencies. I feel it may be neccessary to include another array to do this. Could anybody shed some light on this for me...

ps, the original array can not be altered

I applied the solution and tested the function :

Code:

void find_maxfreq(int A[], int index) {
	int i=0, j=0, maxfreq=1, freq=1, number=0;

	for (i=0 ; i<index; i++) {
		for (j=i+1; j<index; j++) {
			if (A[i]==A[j]) {
				freq++;
			}
		}
		if (freq>maxfreq) {
			maxfreq = freq;
			number = A[i];
			freq = 1;			
		}
		if (freq==maxfreq) {
			if (A[i]<number)
				number = A[i];
			else
				number = number;
			}
		}	
	printf("Max freq : %d\n", maxfreq);
	printf("Value : %d\n", number);
	return;
}

with input : 4 4 4 4 3 3 3 6 6 6
output:

Max freq : 6
Value : 3

as the input shows, the maximum frequency was 4 with 4 repeats. whats going wrong?

cheers vart, and thanks salem. sure our paths will cross again. im such a noob. btw, I barely understand scope with variables, could you be more specific to this example

final code:

Code:

void find_maxfreq(int A[], int index) {
	int i=0, j=0, maxfreq=1, freq=1, number=0;

	for (i=0 ; i<index; i++) {
		for (j=i+1; j<index; j++) {
			if (A[i]==A[j]) {
				freq++;
			}
		}
		if (freq>maxfreq) {
			maxfreq = freq;
			number = A[i];
			freq = 1;			
		}
		if (freq==maxfreq) {
			if (A[i]<number) {
				number = A[i];
				freq = 1;
			}
			else {
				number = number;
				freq = 1;
			}
		}
		freq = 1;	
	}	
	printf("Max freq : %d\n", maxfreq);
	printf("Value : %d\n", number);
	return;
}

working.