Thread: Needed help.

Well, what is the problem, list your input, what the program outputs and the expected output.

Also, use getchar() instead of system("pause").

You declare main as an int (as per standard), but you don't return any values.

Originally Posted by Denisius

What's wrong with this code?

There are a number of points that could be made - Wraithan having already mentioned a couple - but I would suggest that in order to make your program work, look very closely at your variable names all through your program. Check for consistency.

Now then, as for the other things; If you want to be a good C programmer, you are going to have to get familiar with the standard library. Seasoned C coders will tell you that scanf is not the best way to get your integer input. By using scanf, there are just too many problems introduced for what it is worth. You would do well to look into using an fgets + sscanf combo, or perhaps a fgets + strtol combination. All of these functions, especially strtol, provide good error checking so you can control what happens with the user input. Jack Klein offers a good example of strtol in action.

Read your documentation regarding escape sequences. A newline is represented in this manner:

Code:

'\n'

You can pare down your code a little as well:

Code:

if (num > num2 && num > num3) {
        printf("The highest number is: %d\n", num);
    } else if (num2 > num && num2 > num3) {
        printf("The highest number is %d\n", num2);
    } else { /* Neither num1 or num2 is highest
	      * therefore num3 must be highest.
	      */
        printf("The highest number is %d\n", num3);
    }

Finally, turn the warnings up on your compiler. This is very helpful when you have a very tiny / sometimes hard to see bug as the one in your program. It will at least tell you what line to look at, so you don't waste your time poring over all of the code.

~/