What am I doing wrong?

[al_engler]

I am currently taking a C programming course via the internet and need help. I cannot figure out what I am doing wrong within the coding that I have created. I am supposed to be creating my own functions right now, and thought that I was, but apparently not. When I run this code it ask for the input and then does nothing. Any help would be much appriaciated.

#include <stdio.h>

int i;
int liquid1 (int);
int liquid2 (int);
int liquid3 (int);
int liquid4 (int);
int main()
{
printf("Enter cups to be converted:");
scanf ("%d\n",&i);
printf ("gallons = %d\n",liquid1 (i));
printf ("quarts = %d\n",liquid2 (i));
printf ("pints = %d\n",liquid3 (i));
printf ("cups = %d\n",liquid4 (i));

system ("PAUSE");

return 0;
}

int liquid1 (i)
{
int s,g;
g = s/16;
return (g);
}
int liquid2 (i)
{
int f,q;
q=(f%16)/4;
return (q);
}
int liquid3 (i)
{
int d,p;
p=((d%16)%4)/2;
return (p);
}
int liquid4 (i)
{
int l,c;
c=((l%16)%4)%2;
return (c);
}

[jim mcnamara]

for example,

int liquid1 (int i)   <- data type for the parameter "i"
{
int s,g;        <- these are not assigned a value  i needs to be in here somewhere
g = s/16;     <- should this be: g=i/16; ?
return (g);  
}

[al_engler]

I have done what you showed and now get a warning for every funciton that says
"settings\primary\my documents\school\c programming\liq.c:24: warning: declaration of `i' shadows a parameter"

What does that mean? When I run the code it still only asks for the input.

[ZuK]

    scanf("%d\n", &i );

I'm quite shure you don't want that. Only eof or some additional input would stop scanf.
use

    scanf("%d", &i );

jim mcnamara meant

int liquid1 (int i) {
int g;
g = i/16;
return (g);  
}

Kurt

[al_engler]

Thank you, now it works.
I am trying to see if i understand what was happening. By puttingn after the
%d, I was basically stopping the program right there?

[ZuK]

the \n made scanf waiting for some whitespace. but scanf also skips any whitespace after inputting the int so it doesn't see the '\n' after your input and keeps waiting.
some input like

1000 y\n

would have stopped the loop
Kurt

[al_engler]

Thank you for the help, I think I am understanding, hopefully.