Thread: Passing Arrays into functions

I am trying to write a program that will remove any double letters from a surname, ie if I entered harris it would return haris.

I am trying to pass an array which is entered into the main program to the function rmdoub, firstly I get an error in the compiler telling me, incomparable types in assignment on the line where I try to pass the function the array. I have commented on this line to show it.\

I'm not sure what is wrong with the syntax but the program doesn't work and I would really appreciate some help.

Thanks guys

Code:

#include <stdio.h>

char rmdoub(char surname[], int n)
{
    int num;
    int i = 0;
    int j;
    int k;

    while (i < num){
          j = i + 1;
          printf("%d", j);
          printf("%d", i);
          if (surname[j] = surname[i]){
          k = i;
          printf("%d", k);
          printf("%d", num);
           
          num = num - 1;
              while (k < num){
                   surname[k] = surname[j];
                   printf("%s", "c");
                   printf("%s", surname);
                   k = k + 1;
                   j = j + 1;
              }
          }
          num = num + 1;
          i = i + 1;
             
     }
     printf("%s", surname);

}

int main ()
{    
     char surname[40];
     int num;
     char rmsurname[40];
     printf("Please enter the surname you wish to encode into the SOUNDEX index\n");
     scanf("%40s", surname);     
     num = strlen(surname);
     surname[num] = '\0';
     printf("%d", num);
     printf("%s", surname);
     surname = rmdoub(surname, 40); *// This is the line that I am getting an error on//
          
}

*blinded by unreadable yellow comment* Anyways, what doesn't work? Are there compilation errors or does the program not work as expected?
EDIT:rmdoub returns a char. You need to specify a location in surname, such as surname[1]. Also, rmsurname is unused.

Do what I said, use surname[1].

That's because you assign:

Code:

if (surname[j] = surname[i])

This sets j to i. It should be:

Code:

if (surname[j] == surname[i])

Ah, two in a night...feelin' good
p.s. Nice name

I tried using "" around the characters but this gave me an error in compiling about comparing a pointer to an integer.

"" is for strings. '' is for individual characters. They are represented differently internally and cannot be replaced with each other in code, hence the error.

Code:

if (surname[i] == 'a' || 'e' || 'i' || 'o' || 'u')

No, you need to test each one individually.

Code:

if(x == 'a' || x == 'b' //etc...

It depends. The number 9 can be the character '9', if entered as such. If it is already defined as an int, use a function such as itoa.