Greetings, I'm getting an error in my code where I include a header file in more than one location and I get the LNK2005 error during linking. I know that in C a code block is needed around the header file so that it is only included once but I forgot what that code block looks like (I'm used to C++ where this problem doesn't occur).
Isn't it something like?
Am I close? It's been a whileCode:#ifndef HEADER #define HEADER //header code //more header code #ifdef HEADER #endif HEADER
Code:#ifndef HEADER_H #define HEADER_H //header code #endif //HEADER_H
All problems in computer science can be solved by another level of indirection,
except for the problem of too many layers of indirection.
– David J. Wheeler
Hmm, I tried that and I'm still getting the errors. Is there anything else I need?
Header guards don't protect against linker errors.
Guess you defined some variable or function in the header. Headers should only contain declarations.
Kurt
post your header
probably you define some variable or function in the header so linker has more than one instance of the same global object
All problems in computer science can be solved by another level of indirection,
except for the problem of too many layers of indirection.
– David J. Wheeler
You're right, it is because I declare variables and functions inside the header file. Is there anyway around that linker error or do I have to remove the functions and variables?
Yes I know it's bad coding practice to have functions in headers. I just want to know if it is possible.
you should move them to the c-file and leave only function declarations and externs for variables in the header
All problems in computer science can be solved by another level of indirection,
except for the problem of too many layers of indirection.
– David J. Wheeler
Right, I know that's what I *should* do, I was wondering if I had any other options.Originally Posted by vart
Not really.
Sigh, I hate C with a passion. Alright, thanks for the help.
I'm not trying to add insult to injury, but that's why folks should follow the shoulds from the get-go. Most often, the advice that we try to tuck away when we're new is exactly the stuff we should do immediately because we're new. Old timers merely try to prevent other folks from going through the same screwup cycle that we may have gone through.
7. It is easier to write an incorrect program than understand a correct one.
40. There are two ways to write error-free programs; only the third one works.*
