Why this program doesnt work properly
The above program is intended to copy Binary and Text files; However, it does not work correctly. What is the problem?Code:#include<stdio.h> const int MAXLINELEN = 1024; void f(char *ifilename, char *ofilename) { FILE *ifp=fopen(ifilename, "rb"), *ofp=fopen(ofilename, "wb"); char buf[MAXLINELEN]; if(ifp & ofp) while(!feof(ifp)) { fgets(buf, MAXLINELEN,ifp); fputs(buf,ofp); } }
Your AND operator is should be &&, not &, I think...
How does it not work correctly ?
Just off the top of my head, don't use foef to control a loop.
Teacher: "You connect with Internet Explorer, but what is your browser? You know, Yahoo, Webcrawler...?" It's great to see the educational system moving in the right direction
> The above program is intended to copy Binary and Text files
Use fread() and fwrite() then
And don't use feof() as already noted.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
I'm sorry there was a typo in the code.....its actually "...if(ifp && ofp).." and this was one of the question asked in the class....so i need answer to it, i tried find it but could not succeed
Hey, what do you intend to do with this line??
Shouldn't it be an expression?? Not only the variable's name....Code:if(ifp & ofp)
How about this?
Code:if(ifp != NULL && ofp != NULL)
is same asCode:if(ifp != NULL && ofp !=NULL)
Actually in the code there is typo...i typed only "&" instead of "&&"Code:if( ifp && ofp)
> Actually in the code there is typo...i typed only "&" instead of "&&"
Here's a tip - use COPY and PASTE of your actual code which you last tried to compile and run.
Not some half-assed "it looked something like this".
Otherwise we all just waste time finding your typos and then arguing about them rather than focussing on the real question.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Here i have pasted the complete code once again with all correctionsCode:#include<stdio.h> const int MAXLINELEN = 1024; void f(char *ifilename, char *ofilename) { FILE *ifp=fopen(ifilename, "rb"), *ofp=fopen(ofilename, "wb"); char buf[MAXLINELEN]; if(ifp && ofp) while(!feof(ifp)) { fgets(buf, MAXLINELEN,ifp); fputs(buf,ofp); } }
Why don't you just use fread and fwrite? Oh read the FAQ on why it's bad to use feof to control loops.
Quzah.
Hope is the first step on the road to disappointment.
The above question had multiple choice answers which are given below.
choice 1: If the length of the input line is equal to "MAXLINELEN", then result of "fputs" is not defined
choice 2: Long lines cannot be copied by this code
choice 3: If the length of the input line is greater than "MAXLINELEN", then the new line character will not be copied
choice 4: It does not produce an exact copy of some input files.
choice 5: memset(buf,0,MAXLINELEN) is not called before the fgets call.
then i believe the proper question should be "what's bad if i run that code"
Oh, you mean it's an exam question.
"Here is some broken code, which of the following best describes what's wrong with it."
Why don't people post their real question in the first place?
Have you tried running the code with a few test files to see what happens?
Like a line containing only one line - go on, it's fun!
Here's another one
> const int MAXLINELEN = 1024;
This isn't constant enough for C when it comes to declaring your array, so it won't even compile on an ANSI-C compiler.
> What is the problem?
Learning C from an idiot who doesn't know C seems to be one problem
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
