Thread: Calling a function with 50 input variables

I have a bunch of variables declared at the top of my main function. Is there a way I can call a function without creating a mess like the one below?

Code:

some_function(aasdf1,afas2,a33,aaasd4,adhjd5,adghj6,adgf7,a8djfg,a9,q1ffj,q2ff,q3,q4dfg,
q5,6,q7,wff1,w2,w333,wfgjdf4,w5,wdfgj6,w7,e,e1,e2,efgjdfg3,edfgje44,tdfgjdft,ygdfgjsf,
uuu,afas2,a33,aaasd4,adhjd5,adghj6,adgf7,a8djfg,a9,q1ffj,q2ff,q3,q4dfg,q5,6,q7,wff1,w2,
w333,wfgjdf4,w5,wdfgj6,w7,e,e1,e2,efgjdfg3,edfgje44,tdfgjdft,ygdfgjsf,uuu);

???

Should I just use the #define directive? Am I just being lazy?

>I have a bunch of variables declared at the top of my main function. Is there a way I can call a function without creating a mess like the one below?

yes you can, by making the required paramater less in number

Code:

some_function(aasdf1,afas2,a33,aaasd4,adhjd5,adghj6,adgf7,a8djfg,a9,q1ffj,q2ff,q3,q4dfg,
q5,6,q7,wff1,w2,w333,wfgjdf4,w5,wdfgj6,w7,e,e1,e2,efgjdfg3,edfgje44,tdfgjdft,ygdfgjsf,
uuu,afas2,a33,aaasd4,adhjd5,adghj6,adgf7,a8djfg,a9,q1ffj,q2ff,q3,q4dfg,q5,6,q7,wff1,w2,
w333,wfgjdf4,w5,wdfgj6,w7,e,e1,e2,efgjdfg3,edfgje44,tdfgjdft,ygdfgjsf,uuu);

>???
this is as well allowed, tho don't forget to put the paramater type

>Should I just use the #define directive?
of course you can, but you will have to type extra "#define" for each parameter, which is worse

>Am I just being lazy?
you look unneccesarily dilligent to me, don't worry


another idea is to use for loop to pass in your variable

Code:

int i;
for(i = 0; i < SOMETHING; i++) {
   someFunction(i);
}

Hey, what does some_function do? May-be you are making it do too much? May-be some of the variables could be rightfully global? Can you tell what each of the variables/parameters stands for? May-be structs would help?

This sounds like a job for arrays!

You could also put your variables in a structure, then pass the address of the structure to your function.

Sam

Yeah, the numbers at the end of the variable names makes one suspect that arrays should be used somewhere. But then, the variable names look totally random, like a made-up hypothetical example, and it's impossible to diagnose the problem (how on Earth can a function need that many variables) properly.