Thread: simple question again

Well there's a much simpler way to do this: Just keep the input as a string!

Here, one loop:

Code:

#include <stdio.h>
#include <ctype.h>

int main(void)
{
  char *english[] = { "zero", "one", "two", "three", "four", "five", "six", "seven", "eight", "nine" };
  char input[BUFSIZ];
  int i;

  printf("Enter the number: ");
  fflush(stdout);
  fgets(input, sizeof(input), stdin);

  for(i = 0;input[i] && input[i] != '\n';++i)
    if(isdigit(input[i]))
      puts(english[input[i] - '0']);
    else
      puts("unknown");

  return 0;
}

Code:

itsme@itsme:~/C$ ./numtoenglish2
Enter the number: 1234567890,123948
one
two
three
four
five
six
seven
eight
nine
zero
unknown
one
two
three
nine
four
eight
itsme@itsme:~/C$

Well yeah it can be done the other way. It just requires you to think.

You give up so easily! There's 2 obvious solutions:

1) Process the number from the highest place down to the 1's place
2) Store the values from the 1's place to the highest place and then print them out in reverse order

Someone already showed you a solution using option 1, but you make it sound like it's impossible to do it that way.

Well for one thing the closing brace that terminates your switch statement is misplaced, putting the printf() in a case statement after the break, so it never executes.

Code:

   while(number !=0)
   {
       right_digit = number % 10;          //extracts 3
       
       number/=10;         //get the next digit = 2
       newnum = newnum + right_digit;  
        
        }

In this code (besides working on the indentation) you need to multiply newnum by 10 each time, otherwise, if the number is 123, newnum will be 1+2+3=6 instead of 321.

Code:

    while(number !=0)
    {
        right_digit = number % 10;          //extracts 3
        
        number/=10;         //get the next digit = 2
        newnum = newnum + right_digit;  
        newnum *= 10;
    }

If you do that, and number is 123, then newnum will be 321 (assuming you initialize newnum to zero, which you do).

I think you should take itsme86's suggestion and read the input as a string, not as a number. That way the digits are already in the right order and all you have to do is parse the string with a for loop.

Sorry if this adds more confusion, but recursion can make the "reversing" simple.

Code:

#include <stdio.h>

void foo(int value)
{
   static const char *digit[] = 
   {
      "zero", "one", "two", "three", "four", 
      "five", "six", "seven", "eight", "nine",
   };
   if ( value > 0 )
   {
      foo(value / 10);
      printf("%s ", digit [ value % 10 ] );
   }
}

int main(void)
{
   foo(135);
   putchar('\n');
   return 0;
}

/* my output
one three five 
*/