what is wrong with the input?

**timhxf** · 08-11-2006

hi, I am a new lover of C,I have recently written the code below, it is a program to guess the number.

Code:

#include<stdio.h>
int main(void)
{
    
    int a;
    char response;
    
  printf("pls pick up a no from 1 to 100:");
  printf("is your no 50?");
  if((response=getchar())=='l')
  {
  a=75;
  printf("is your no %d",a);
             while((response=getchar())!='y')
             {
              if((response=getchar())=='h')
              {
              a=50+(a-50)/2;
              printf("is your no %d",a);
              }
               else
               {
               a=a+(100-a)/2;
               printf("is your no %d",a);
               }
                }
                 printf("I got it,haha!");
                           }
                           else if((response=getchar())=='h')
                           {
                           a=25;
                           printf("is your no %d",a);
                                      while((response=getchar())!='y')
                                      {
                                          if((response=getchar())=='h')
                                          {
                                          a=(a-1)/2;
                                          printf("is your no %d",a);
                                          }
                                           else
                                           {
                                           a=a+(50-a)/2;
                                           printf("is your no %d",a);
                                                      }
                                                           }
                                                           printf("I got it,haha!");
                                                                     }
                                                                      else
                                                                                                                                                                      
                                                                      printf("I got it, haha!");
                               
                              
system("pause");
return 0;
}

first I typed in "l", then it prompted me with "is your no 75", I typed in "y" right after that, and what I got was "is your no 87". but it should print out "I got it, haha!" from the logic of the program. I tried typing a space before typing "y", and it gave me another guess with "I got it,haha!" (two sentence together). can anybody tell me what was wrong? Thanks.

**itsme86** · 08-11-2006

Good lord. What did you do with your indentation? Lining everything up in a reasonable manner would be a good first step to figuring out what's wrong (and getting other people more apt to look at your code).

**kermit** · 08-11-2006

A present for the OP...

Code:

#include<stdio.h>

int main(void)
{

    int a;
    char response;

    printf("pls pick up a no from 1 to 100:");
    printf("is your no 50?");
    if ((response = getchar()) == 'l') {
        a = 75;
        printf("is your no %d", a);
        while ((response = getchar()) != 'y') {
            if ((response = getchar()) == 'h') {
                a = 50 + (a - 50) / 2;
                printf("is your no %d", a);
            } else {
                a = a + (100 - a) / 2;
                printf("is your no %d", a);
            }
        }
        printf("I got it,haha!");
    } else if ((response = getchar()) == 'h') {
        a = 25;
        printf("is your no %d", a);
        while ((response = getchar()) != 'y') {
            if ((response = getchar()) == 'h') {
                a = (a - 1) / 2;
                printf("is your no %d", a);
            } else {
                a = a + (50 - a) / 2;
                printf("is your no %d", a);
            }
        }
        printf("I got it,haha!");
    } else

        printf("I got it, haha!");

    return 0;
}

Like itsme86 said - your indenting is bad news.

**itsme86** · 08-11-2006

It looks like your problem is you're forgetting the newline character. When you type "y<ENTER>" the first getchar() will grab the y and the next getchar() will grab the '\n' from pressing ENTER.

Now say "thank you, kermit".

**timhxf** · 08-12-2006

I see, thanks for you guys to help me, sorry for the bad indentation, I should improve on that also.
I did a review of my code, and came out the code here:

Code:

#include<stdio.h>
int main(void)
{
    
    int a;
    char response;
    
  printf("pls pick up a no from 1 to 100:");
  printf("is your no 50?");
  if((response=getchar())=='l')
  {
  printf("%c",response);
  a=75;
  printf("is your no %d",a);
   while(getchar()!='\n')
   continue;
 
    while((response=getchar())!='y')
    {
     if(response=='h')
     {
     a=50+(a-50)/2;
     printf("is your no %d",a);
     while(getchar()!='\n')
     continue;
     }
     else
     {
     a=a+(100-a)/2;
     printf("%c",response);
     printf("is your no %d",a);
     while(getchar()!='\n')
     continue;
     }
    }
    printf("I got it,haha!");
   }
   else if((response=getchar())=='h')
   {
   a=25;
   printf("is your no %d",a);
   while(getchar()!='\n')
   continue;
   while((response=getchar())!='y')
    {
    if(response=='h')
     {
     a=(a-1)/2;
     printf("is your no %d",a);
     while(getchar()!='\n')
     continue;
     }
     else
     {
     a=a+(50-a)/2;
     printf("is your no %d",a);
     while(getchar()!='\n')
     continue;
     }
    }
    printf("I got it,haha!");
   }
   else
   printf("I got it, haha!");
system("pause");
return 0;
}

it is working when I first gave the answer "low". but it gives me "I got it, haha!" after I keyed in "high"(it should take a guess of 25 instead).
I cannot find anything wrong with the conditonal statements

Thread: what is wrong with the input?

Thread Tools

Search Thread

Display

what is wrong with the input?

thank you

Similar Threads

Problem grabbing k/b input

About aes

How can I repeat a menu on wrong input?

Problem with input choice... Somethings wrong... really wrong....