Thread: Simple problem with string... Please take a look

Im using the following scratch code to take a string (stream/buffer, w.e) and run it through this function to replace whateer char i give it, with another char i give it...

Code:

#include <string.h>
#include <stdio.h>

extern int Replacing(const char* replacing, char replacement, char* string)
{
  char *string_ptr;
  while((string_ptr=strpbrk(string,replacing))!=NULL)
    *string_ptr=replacement;
return *string_ptr;
}

int main() {
           char *buffer;
           int string;
           char test[] = "This is a testing string";
           *buffer = Replacing(" ", '-', test);
           string = &buffer;
           printf("\nAfter:\n%s", string);
           while(1) {  
                   }
return 0;
}

It should read the string, and replace all ' ' AKA spaces, with '-' or minus signs...

The error im getting when using the Bloodshed Dev-C++ MingGW Complier is:

Code:

assignment makes integer from pointer without a cast

This obviously is the problem as it is the only error (warning really)...

Im sure its a simple answer, Im 14, so bear with me... Started programming about 2 days a go, do you think im making good progress?

Are you sure your compiler even has strpbrk? It's not an ANSI standard function.


Quzah.

Try this

Code:

#include <string.h>
#include <stdio.h>

char *Replacing(const char* replacing, char replacement, char* string)
{
  char *string_ptr;
  while((string_ptr=strpbrk(string,replacing))!=NULL  )
    *string_ptr=replacement;
  return string;
}

int main() {
  char *buffer;
  char test[] = "This is a testing string";
  buffer = Replacing(" ", '-', test);
  printf("\nAfter:\n%s", buffer);
  return 0;
}

ok... ill tell you soon...Yup it worked, tahnks alot... any idea why mine wasn't working? I have somewhat of an idea now... (but its like my 3rd day of first being introduced to programming so that's my excuse )

You were using a single character, not a string.

Code:

 4 : extern int Replacing(char *string, char replacing, char replacement)

 9 :   while((string_ptr=strpbrk(string,replacing))!=NULL  )

Pay attention to what arguments functions expect:

SYNOPSIS
#include <string.h>

char *strpbrk(const char *s, const char *accept);


DESCRIPTION
The strpbrk() function locates the first occurrence in the
string s of any of the characters in the string accept.

Quzah.