Thread: Infinite loop

Think about each line in the file, what does each line end with? Compare that value to what the actual file ends with. Are they different?


[EDIT]
Hmm, after thinking about this for a while, it does seem strange that the inner loop is infinite.

Yeh, my initial thoughts about the newline character were wrong. I'm just testing the code now to see what the issue is.

[EDIT]
You might need to post the rest of your code, because this works fine for me:

Code:

#include <stdio.h>
#include <stdlib.h>
#define MAX_COLUMNS 80

int main(int argc, char *argv[])
{
    int i;
    FILE *fp;
    char *filename = "balls.txt";
    char thisline[100];
    
    fp = fopen( filename, "r" );
    
    while ( NULL != fgets(thisline, MAX_COLUMNS + 1, fp))
    {
          i = 0;
          
          while ( '\0' != thisline[i] )
          {
                i++;
                printf("%d\n", i);
          }
    }

    system("PAUSE");	
    return 0;
}

Text file:

1asd asdas as asf asf
2ihasdia sdqad qewf qw ef
3khafdwe wef we fwe f

[EDIT v2]

Bahahaha, I'm an idiot, I was right.

This line should be ( for future reference ):

Code:

while(('\n' != thisline[i]) && ('\0' != thisline[i]))

Yep, that'll do it. :P

> OUCH! Assignment issue. Usually I'm good about keeping the lvalues to the left!
You're focussing on the wrong issue.
http://cboard.cprogramming.com/showthread.php?t=79373
You need to increase the warning level of your compiler, or get a compiler which will warn you about using = where == was more likely.

> if(i = 0)
Of course, if this had been in your first post rather than your third, then the answer would have been much more obvious.
Don't paraphrase code by snipping bits out, because you're just going to snip out the bit which is important.

> fgets(thisline, MAX_COLUMNS + 1, fp)
Don't lie about the size of your buffer to fgets(). If you want to add 1, add it in the array
char thisline[MAX_COLUMNS+1];
fgets( thisline, sizeof thisline, fp );

> char thisline[100];
This has nothing to do with your macro size - change either and fgets() could be in big trouble.

Originally Posted by Salem

> char thisline[100];
This has nothing to do with your macro size - change either and fgets() could be in big trouble.

Yeh sorry, that was my mistake, I just did it for my testing.