Thread: simple C program

Hi,

I am a newbie, and i am trying to write my first few simple programs in C. In the following example i am trying to write a small program which gives me the factorial of a particular number, however, when i hit the "x" key, i would like to terminate the program.

This is the code which i tried:

Code:

/*Program to find the factorial of 6 */

#include <stdio.h>

int i,j;
int value;

int main()
{


      char keypress;
      do
      {
       printf("Enter a value to which you want the factorial: ");
       scanf("%d", &value);
       j=1;
       for (i=1; i<=value; i++)
       j=j*i;
       printf("The factorial of %d is %d\n", value, j);
      }
      while (keypress != "x");
      return 0;
      system("PAUSE");
}

When i run the program, it works fine, however, as soon as i hit the "x" key the program will run into an endless loop giving me the factorial number of the last number which i checked for.

Can someone tell me what i do have wrong please ?

Many thanks in advance.

U have't accepted value for "keypress"
Add statement scanf("%s",&keypress); after last printf(); then it should work

thx for your reply, i have added the line as you suggested, however, when i hit the x key i am still not getting the program to terminate, but instead when i hit the enter key, i will get the printf statement of the last inputted number ?

Any ideas what i am doing wrong pls ?

Thanks

Are u hitting enter key after pressing x???

well when i added the line you suggested me, after i type a number and get the factorial, i am not getting the printf statement to input another factorial, so whatever key i press (including x) nothing happens, so i have to hit enter, and then i get the printf statement to input another number.

Thanks

Hi,

this is the new amended code :

Code:

/*Program to find the factorial of 6 */

#include <stdio.h>
#include <stdlib.h>

int i,j;
int value;

int main()
{


      char keypress;
      while (keypress != "x")
      {
       printf("Enter a value to which you want the factorial: ");
       scanf("%d", &value);
       j=1;
       for (i=1; i<=value; i++)
       j=j*i;
       printf("The factorial of %d is %d\n", value, j);
       scanf("%s", &keypress);
      }
      return 0;
      system("PAUSE");
}

Kindly note that i tried putting the while statement at the beginning, but still to the same result

Thanks

spydoor, thank you very much for your reply. the %s was the culprit because as soon as i've changed it to %c, the program ran as expected.

I really appreciate your help.