Thread: dir output problems

hey, i'm exploring the Accessing a directory and all the files within it example in the faq for win32, and i've found a way to output the filenames to a file.

Code:

// print out in sorted order
  int numdirs = 0;
  for (i = 0; i < list.num_entries; i++)
  {
    char  t1[50], t2[50], t3[50], a[10];
    format_time(&list.files[i].ftCreationTime, t1);
    format_time(&list.files[i].ftLastAccessTime, t2);
    format_time(&list.files[i].ftLastWriteTime, t3);
    format_attr(list.files[i].dwFileAttributes, a);
    if (list.files[i].dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
    {
      // 'null' date for directory access times, which change each time
      // we run this tool
      sprintf(t2, "%4d/%02d/%02d %02d:%02d:%02d", 2000, 1, 1, 0, 0, 0);
    }
    
    
        fprintf(fileptr, "%s\n", list.files[i].cFileName);

    printf("%s %10ld %s %s %s %s\\%s\n", a, list.files[i].nFileSizeLow, t1, t2, t3, root, list.files[i].cFileName);
    if (list.files[i].dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) numdirs++;
  }

problem is, if theres multiple dir's, it creates the file in each dir and outputs the content to that file. what i want it to do, is output all of the files to the txt file in the root dir. similar to the dos command: dir /s /b > output.txt

any help is welcome :] thx

> fileptr
Pass this as a parameter, which is fopen() and fclose() in the main function.

void doit(char *root, FILE *fileptr);

doit(newroot,fileptr);

works like a charm

now the only problem i have is telling which file(s) belong in which directory(/ies). it outputs the folder name(s), and then the filename(s) of the file(s) in the current folder, and then the filename(s) of the file(s) in the next folder deep, etc. also if there's two files with the same name, one in the root dir and one in a sub dir, it only outputs the filename once. is there a way i could add like \subdir\ to filename.ext before it gets output?

thanks



// also, the program isn't perfect. i created 3 directories, each with a file in the directory and it only lists those files in the first directory. i modified the doit() function to accept another string to output as to which dir it's in.

Code:

void doit(char *root, FILE *fileptr, char *sub)
{     
  flist           list = { 0, 0, NULL };
  HANDLE          h;
  WIN32_FIND_DATA info;
  int             i;

  // build a list of files
  h = FindFirstFile("*.*", &info);
  if (h != INVALID_HANDLE_VALUE)
  {
    do
    {
      if (!(strcmp(info.cFileName, ".") == 0 || strcmp(info.cFileName, "..") == 0))
      {
        addfile(&list, info);
      }
    } while (FindNextFile(h, &info));
    if (GetLastError() != ERROR_NO_MORE_FILES) errormessage();
    FindClose(h);
  }
  else
  {
    errormessage();
  }

  // sort them
  qsort(list.files, list.num_entries, sizeof(list.files[0]), sortfiles);

  // print out in sorted order
  int numdirs = 0;
  for (i = 0; i < list.num_entries; i++)
  {
    char  t1[50], t2[50], t3[50], a[10];
    format_time(&list.files[i].ftCreationTime, t1);
    format_time(&list.files[i].ftLastAccessTime, t2);
    format_time(&list.files[i].ftLastWriteTime, t3);
    format_attr(list.files[i].dwFileAttributes, a);
    if (list.files[i].dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
    {
      // 'null' date for directory access times, which change each time
      // we run this tool
      sprintf(t2, "%4d/%02d/%02d %02d:%02d:%02d", 2000, 1, 1, 0, 0, 0);
    }
    
        fprintf(fileptr, "%s", sub);
        fprintf(fileptr, "%s\n", list.files[i].cFileName);

    printf("%s %10ld %s %s %s %s\\%s\n", a, list.files[i].nFileSizeLow, t1, t2, t3, root, list.files[i].cFileName);
    if (list.files[i].dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) numdirs++;
  }

  // now process all the sub-dirs
  // free all the files first, to save a bit of space
  // the sort function will have put them all at the end.
  list.files = (WIN32_FIND_DATA *) realloc(list.files, numdirs * sizeof(WIN32_FIND_DATA));
  for (i = 0; i < numdirs; i++)
  {
    char  newroot[MAX_PATH];
    char sub[100] = ".\\";
    sprintf(newroot, "%s\\%s", root, list.files[i].cFileName);
    SetCurrentDirectory(list.files[i].cFileName);
    strcat(sub, list.files[i].cFileName);
    strcat(sub, "\\");
    doit(newroot, fileptr, sub);
    SetCurrentDirectory("..");
  }

  // free the remainder
  free(list.files);
  
  fclose(fileptr);
}

program output:

.\ay
.\nameoffolder
.\shibby
.\anotherfile.txt
.\dirlist.txt
.\xtree.cpp
.\xtree.exe
.\ay\lukeiamyourfather.txt

output of dir /s /b

C:\Documents and Settings\Tim Hansen\My Documents\cpp\anotherfile.txt
C:\Documents and Settings\Tim Hansen\My Documents\cpp\ay
C:\Documents and Settings\Tim Hansen\My Documents\cpp\dirlist.txt
C:\Documents and Settings\Tim Hansen\My Documents\cpp\nameoffolder
C:\Documents and Settings\Tim Hansen\My Documents\cpp\output.txt
C:\Documents and Settings\Tim Hansen\My Documents\cpp\shibby
C:\Documents and Settings\Tim Hansen\My Documents\cpp\xtree.cpp
C:\Documents and Settings\Tim Hansen\My Documents\cpp\xtree.exe
C:\Documents and Settings\Tim Hansen\My Documents\cpp\ay\lukeiamyourfather.txt
C:\Documents and Settings\Tim Hansen\My Documents\cpp\nameoffolder\yousuck.txt
C:\Documents and Settings\Tim Hansen\My Documents\cpp\shibby\POS.txt

lol slight difference..

Well you have two 'sub' in scope.
You need to append the new sub-directory onto the end of the parameter sub, not create a new one from scratch.