Cant close file pointer
Hi
i get a segmentation fault when i want to close a file i have opened
here is the code
it seg faults on fclose and i cant free tempCode:char *temp; temp = (char *)malloc(1000); ....... if ((fi = fopen(fiPath, "r")) == NULL) { fprintf(stderr, "Error reading file: %s\n", fiPath); fo = NULL; return; } /* copy the whole file into a temp memory location */ while (fgets(line_buffer, 80, fi) != NULL) strcat(temp, line_buffer); fclose(fi); free(temp);
Consider posting a working (or in this case, non working), compilable example, instead of some random crap. Also, instead of strcating everything over and over, instead, ignore allocation, and simply print the line. My guess is you're running off the end of temp, and it just appears to fail on fclose or free.
Quzah.
Hope is the first step on the road to disappointment.
Seems like there is a problem with the strcat
How would you dump the entire file into memory?
It depends what you want to do with it. There are many ways. You could...
a - Use realloc, and reallocate your buffer bigger and bigger each time, appending what you've read onto it.
b - Use a linked list, store a...b1 - character per node.c - Recursively read a character at a time, doing nothing more than displaying it in said recursive call. (Small files only.
b2 - line per node.
b3 - page per node.
b4 - etc.)
d - Other fun things, left up for other readers...
Really though, it depends on what you want to do with it. Try them all, if you're bored.
Quzah.
Hope is the first step on the road to disappointment.
First problem is you cast the return result of malloc.
The second problem is that you assume the allocated memory has the first byte as \0, for strcat to work effectively with. malloc returns memory in an undefined state.
The third problem is are you assuming that the file is always <1000 bytes?
The Fourth problem is how did you declare line_buffer?
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
