Thread: Game Pointer Trouble?

By compileable, I meant something that can compile.

[edit]Since for an array of size N, it is addressable from 0 to N-1. Or

Code:

for ( i =0; i < N; ++i)

[/edit]

Your idiom generally overshoots the array size by one.

[edit=2 or 3]But then I'm having an off night.

Code:

#define GraphicsSize(Block)	(Block->Size + 1)
#define GraphicsNumber(Block)	(Block->Number + 1)

struct GraphicsBlock
{
	unsigned char Size;		// Width & Height
	unsigned char Number;
	unsigned char **Images;
} Tiles;

int LoadGraphics(const char *Filename, struct GraphicsBlock *Block)
{
	FILE *File;
	int Character;
	unsigned char Number;

	if ((File = fopen(Filename, "rb")) == NULL)
	{
		// Couldn't open the file: "Filename".
		return 1;
	}

	if ((Character = fgetc(File)) == EOF)
	{
		// Couldn't get the images sizes.
		fclose(File); return 1;
	}
	Block->Size = Character;

	if ((Character = fgetc(File)) == EOF)
	{
		// Couldn't get the number of images.
		fclose(File); return 1;
	}
	Block->Number = Character;

	Block->Images = malloc(GraphicsNumber(Block) * sizeof(unsigned char *));
	if (Block->Images == NULL)
	{
		// Out of memory for storing image locations.
		fclose(File); return 1;
	}

	for (Number = 0; Number <= Block->Number; Number++)
	{
		Block->Images[Number] = malloc(GraphicsSize(Block) * GraphicsSize(Block));
		if (Block->Images[Number] == NULL)
		{
			// Not enough memory for storing the images.
			for (Character = 0; Character < Number; Character++)
				free(Block->Images[Character]);
			fclose(File); free(Block->Images); return 1;
		}

		if (fread(Block->Images[Number], GraphicsSize(Block) * GraphicsSize(Block), 1, File)
			!= GraphicsSize(Block) * GraphicsSize(Block))
		{
			// Couldn't read images from the file.
			for (Character = 0; Character <= Number; Character++)
				free(Block->Images[Character]);
			fclose(File); free(Block->Images); return 1;
		}
	}

	fclose(File); return 0;
}

MAKE Version 5.2 Copyright (c) 1987, 2000 Borland
c:\progra~1\lint\lint-nt.exe -Ic:\progra~1\borland\bcc55\include -Ic:\progra~1\lint std.lnt env-sled.lnt co-bc5.lnt -zero test.c -oo(test.lob)
PC-lint for C/C++ (NT) Ver. 8.00e, Copyright Gimpel Software 1985-2001

--- Module: test.c
test.c 13 error [Error 40] Undeclared identifier 'FILE'
test.c 13 error [Error 40] Undeclared identifier 'File'
test.c 13 error [Warning 522] Expected void type, assignment, increment or decrement
test.c 14 error [Error 42] Expected a statement
test.c 15 error [Error 42] Expected a statement
test.c 17 error [Error 40] Undeclared identifier 'File'
test.c 17 error [Info 718] Symbol 'fopen' undeclared, assumed to return int
test.c 17 error [Info 746] call to function 'fopen()' not made in the presence of a prototype
test.c 17 error [Error 63] Expected an lvalue
test.c 17 error [Error 40] Undeclared identifier 'NULL'
test.c 23 error [Error 40] Undeclared identifier 'Character'
test.c 23 error [Info 718] Symbol 'fgetc' undeclared, assumed to return int
test.c 23 error [Info 746] call to function 'fgetc()' not made in the presence of a prototype
test.c 23 error [Error 40] Undeclared identifier 'File'
test.c 23 error [Error 63] Expected an lvalue
test.c 23 error [Error 40] Undeclared identifier 'EOF'
test.c 26 error [Info 718] Symbol 'fclose' undeclared, assumed to return int
test.c 26 error [Info 746] call to function 'fclose()' not made in the presence of a prototype
test.c 26 error [Error 40] Undeclared identifier 'File'
test.c 28 error [Error 40] Undeclared identifier 'Character'
test.c 30 error [Error 40] Undeclared identifier 'Character'
test.c 30 error [Error 40] Undeclared identifier 'File'
test.c 30 error [Error 63] Expected an lvalue
test.c 30 error [Error 40] Undeclared identifier 'EOF'
test.c 33 error [Error 40] Undeclared identifier 'File'
test.c 35 error [Error 40] Undeclared identifier 'Character'
test.c 37 error [Info 718] Symbol 'malloc' undeclared, assumed to return int
test.c 37 error [Info 746] call to function 'malloc()' not made in the presence of a prototype
test.c 37 error [Error 64] Type mismatch (assignment) (unsigned char ** = int)
test.c 38 error [Error 40] Undeclared identifier 'NULL'
test.c 41 error [Error 40] Undeclared identifier 'File'
test.c 44 error [Error 40] Undeclared identifier 'Number'
test.c 44 error [Error 63] Expected an lvalue
test.c 44 error [Error 40] Undeclared identifier 'Number'
test.c 44 error [Error 40] Undeclared identifier 'Number'
test.c 44 error [Error 52] Expected an lvalue
test.c 46 error [Error 40] Undeclared identifier 'Number'
test.c 46 error [Warning 516] 'Symbol malloc()' has arg. type conflict (arg. no. 1 -- signed/unsigned) with line 37
test.c 37 error [Info 830] Location cited in prior message
test.c 46 error [Error 63] Expected an lvalue
test.c 47 error [Error 40] Undeclared identifier 'Number'
test.c 47 error [Error 40] Undeclared identifier 'NULL'
test.c 50 error [Error 40] Undeclared identifier 'Character'
test.c 50 error [Error 63] Expected an lvalue
test.c 50 error [Error 40] Undeclared identifier 'Character'
test.c 50 error [Error 40] Undeclared identifier 'Number'
test.c 50 error [Error 40] Undeclared identifier 'Character'
test.c 50 error [Error 52] Expected an lvalue
test.c 51 error [Info 718] Symbol 'free' undeclared, assumed to return int
test.c 51 error [Info 746] call to function 'free()' not made in the presence of a prototype
test.c 51 error [Error 40] Undeclared identifier 'Character'
test.c 52 error [Error 40] Undeclared identifier 'File'
test.c 52 error [Warning 516] 'Symbol free()' has arg. type conflict (arg. no. 1 -- basic) with line 51
test.c 51 error [Info 830] Location cited in prior message
test.c 55 error [Info 718] Symbol 'fread' undeclared, assumed to return int
test.c 55 error [Info 746] call to function 'fread()' not made in the presence of a prototype
test.c 55 error [Error 40] Undeclared identifier 'Number'
test.c 55 error [Error 40] Undeclared identifier 'File'
test.c 59 error [Error 40] Undeclared identifier 'Character'
test.c 59 error [Error 63] Expected an lvalue
test.c 59 error [Error 40] Undeclared identifier 'Character'
test.c 59 error [Error 40] Undeclared identifier 'Number'
test.c 59 error [Error 40] Undeclared identifier 'Character'
test.c 59 error [Error 52] Expected an lvalue
test.c 60 error [Error 40] Undeclared identifier 'Character'
test.c 61 error [Error 40] Undeclared identifier 'File'
test.c 61 error [Warning 516] 'Symbol free()' has arg. type conflict (arg. no. 1 -- basic) with line 51
test.c 51 error [Info 830] Location cited in prior message
test.c 65 error [Error 40] Undeclared identifier 'File'

--- Global Wrap-up

test.c 11 error [Info 714] Symbol 'LoadGraphics(const char *, struct GraphicsBlock *)' (line 11, file test.c) not referenced
test.c 51 error [Warning 526] 'free()' (line 51, file test.c) not defined
test.c 51 error [Warning 628] no argument information provided for function 'free()' (line 51, file test.c)
test.c 26 error [Warning 526] 'fclose()' (line 26, file test.c) not defined
test.c 26 error [Warning 628] no argument information provided for function 'fclose()' (line 26, file test.c)
test.c 23 error [Warning 526] 'fgetc()' (line 23, file test.c) not defined
test.c 23 error [Warning 628] no argument information provided for function 'fgetc()' (line 23, file test.c)
test.c 37 error [Warning 526] 'malloc()' (line 37, file test.c) not defined
test.c 37 error [Warning 628] no argument information provided for function 'malloc()' (line 37, file test.c)
test.c 17 error [Warning 526] 'fopen()' (line 17, file test.c) not defined
test.c 17 error [Warning 628] no argument information provided for function 'fopen()' (line 17, file test.c)
test.c 9 error [Info 714] Symbol 'Tiles' (line 9, file test.c) not referenced
test.c 55 error [Warning 526] 'fread()' (line 55, file test.c) not defined
test.c 55 error [Warning 628] no argument information provided for function 'fread()' (line 55, file test.c)
Outputting to file test.lob
c:\progra~1\borland\bcc55\bin\bcc32 -P- -c @MAKE0000.@@@
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
test.c:
Error E2303 test.c 6: Type name expected
Error E2040 test.c 6: Declaration terminated incorrectly
Error E2451 test.c 13: Undefined symbol 'FILE' in function LoadGraphics
Error E2451 test.c 13: Undefined symbol 'File' in function LoadGraphics
Error E2140 test.c 14: Declaration is not allowed here in function LoadGraphics
Error E2140 test.c 15: Declaration is not allowed here in function LoadGraphics
Error E2451 test.c 17: Undefined symbol 'NULL' in function LoadGraphics
Error E2188 test.c 19: Expression syntax in function LoadGraphics
Error E2380 test.c 19: Unterminated string or character constant in function LoadGraphics
Error E2129 test.c 19: Character constant must be one or two characters long in function LoadGraphics
Error E2451 test.c 23: Undefined symbol 'EOF' in function LoadGraphics
Error E2188 test.c 25: Expression syntax in function LoadGraphics
Error E2380 test.c 25: Unterminated string or character constant in function LoadGraphics
Error E2129 test.c 25: Character constant must be one or two characters long in function LoadGraphics
Error E2188 test.c 32: Expression syntax in function LoadGraphics
Error E2380 test.c 32: Unterminated string or character constant in function LoadGraphics
Error E2129 test.c 32: Character constant must be one or two characters long in function LoadGraphics
Error E2451 test.c 35: Undefined symbol 'Number' in function LoadGraphics
Error E2451 test.c 37: Undefined symbol 'Number' in function LoadGraphics
Warning W8069 test.c 37: Nonportable pointer conversion in function LoadGraphics
Error E2188 test.c 40: Expression syntax in function LoadGraphics
Error E2451 test.c 44: Undefined symbol 'Number' in function LoadGraphics
Warning W8069 test.c 46: Nonportable pointer conversion in function LoadGraphics
Error E2188 test.c 49: Expression syntax in function LoadGraphics
Error E2379 test.c 50: Statement missing ; in function LoadGraphics
Error E2188 test.c 58: Expression syntax in function LoadGraphics
Error E2380 test.c 58: Unterminated string or character constant in function LoadGraphics
Error E2228 test.c 58: Too many error or warning messages in function LoadGraphics
*** 26 errors in Compile ***

** error 1 ** deleting test.obj

It's less easy this way.