Thread: Having problem printing **string

Hi I am new to C (been working with it for about 2 months by myself)
and I have a problem I found an exercise where i am to create a twodimensional array of strings and rearrange after taking in consideration some criteria.... Anyway I am in the beginning and I have allocated space for my array and read the strings but for some reason it prints only the first 3 letters of each string....

Code:

#include <stdio.h>
 #define STR_LEN 25  
  void creation(char **,int);
 
main()
{
 char **string;
 int i,size;
 
 	printf("How many rows do you want?  ");
	scanf("%d",&size);
	fflush(stdin);
	string=(char **) malloc(size*sizeof(char *));
	creation(string,size);
	for (i=0;i<size;i++)
		fputs(*(string+i),stdout); //i've also tried printf("%s",*(string+i));
	system("pause");
	
}

void creation(char **str,int size)
{
 int i;
 	
 	for(i=0;i<size;i++)	{
 		*(str+i)=(char *) malloc(STR_LEN*sizeof(char));
 		printf("String No%d: ",i+1);
 		fgets(*(str+i),sizeof(*(str+i)),stdin);
 		fflush(stdin);
	}
}

If someone can help me I d really appreciate it...Oh and if someone can explain me what is better for printing (printf,fputs....) and reading (sscanf,scanf,fgets,....)

The mistake is here

Code:

 		fgets(*(str+i),sizeof(*(str+i)),stdin);

*(str+i) is a pointer so sizeof(*(str+i)) returns 4 on a ia32. -> fgets will stop reading after 4 characters.
BTW char **string is not a 2-dim array of strings.
It's eiter an array of strings or a 2-dim array of char.

Kurt

> fflush(stdin);
Read the FAQ - stdin isn't a stream you can fflush

> string=(char **) malloc(size*sizeof(char *));
Read the FAQ on casting malloc. You've just hidden the fact that you didn't include stdlib.h

> fgets(*(str+i),sizeof(*(str+i)),stdin);
Rather than all this str+i, just write
fgets(str[i],STR_LEN,stdin);

ZuK and Salem thanks a lot. Yeah you are right ZuK that's waht i meant (2-dim array of char). I see what you mean about size of, I had originally used STR_LEN but i changed it (dont know why though, shows my inexperience).... Anyway thanks a lot.
By the way does it matter if i use *(str+i) instead of str[i], I wondered about that

Originally Posted by Phoenix_Rebirth

By the way does it matter if i use *(str+i) instead of str[i], I wondered about that

There is no difference. In my opinion str[i] is easier to read.
Kurt