watz wrong here?

[sifeet]

Hey,
This is the part of my code for Hangman game where player make a correct guess and the program should display it as (for ex) _ _ _ s _ _ s _

len is the lenght of the word.
word is the word that computer randoms
guess is the letter the player choose

for(k=0;k<len;k++){
    if(guess==word[k]){
      index=k;
      for(i=0;i<len;i++){
	if(i!=index)
	  printf("-\n");
	  else
	    printf("&#37;s",word[index]);
      }
    }
 }

what's the problem here?!

[Elysia]

Uhh yeah, like we can see the problem with such a short bit of code. The code is entirely dependant upon the variables, so post more code to illustrate the problem!
You could also indent a little better. Use a tab (or 4 spaces) on each block - increases readability. If and else should be on the same indent level - again, increases readability.
And I also hope that you declared word to be a 2D array.

[sifeet]

sorry :P here it comes the whole program.
(actually not the whole. but I'm still working on this part.)

#include<stdio.h>
#include<stdlib.h>
#include<stdbool.h>
#include<time.h>

int main(){

   int x,i,j,k,h,len,dr,index;
   char guess;
   char flt[9][20];
   char* word;
  
  FILE *sep; 
  sep=fopen("hangman.dat","r");
  for(i=0;i<9;i++){
    fgets(flt[i],20,sep);
  }
  fclose(sep);
  srand( time(0) );
  j=rand()&#37;8+1;
  word=flt[j];
  len=strlen(word);
  printf("%s",word);
  while(true){
    printf("Guess a letter:\n");
    getchar();
    scanf("%c",&guess);
    for(k=0;k<len;k++){
      if(guess==word[k]){
	index=k;
	for(i=0;i<len;i++){
	  if(i!=index)
	    printf("-");
	  else
	    printf("%s",word[index]);
         }
       }
     }
   } 
    return 0;
}

[Elysia]

OK, so does that compile? Because true isn't a keyword in C.
Missing ; at the printf and the if.
h, x and dr are unreferenced.
return 0 at the end of main is never reached due to your endless loop.
And also check if you failed to open the file and print an error!

[sifeet]

OK, so does that compile? Because true isn't a keyword in C.
Missing ; at the printf and the if.
h, x and dr are unreferenced.
return 0 at the end of main is never reached due to your endless loop.
And also check if you failed to open the file and print an error!

yes, it does compile! I just maybe missed the ";" sign when copy-pasting. and those unreferenced variables are for the other part of the code which I put comment sign around. and strangely it is not occurred as an error!
anyway it compiles and I can run it.
for ex the random word is organization. I type "g" and what is displayed afterward is 12 times of this character " _" ! it never checks the letter I entered =(

and why is the loop endless? I'm trying to traverse the string and that is not endless!?!

[Elysia]

getchar fetches your first input and scanf later fails.
And the actual while(true) loop is endless.

[t3chn0n3rd]

which compiler are you usinig?

[Elysia]

I use Visual Studio 2008.

[ssharish2005]

i can see why u are using getchar before scanf function, but i would suggest to use just the getchar function and remove scanf call. Get the return value getchar in a variable and then process on it.

And about the problem itself. Why dont use read on complete word from the user rather than eah char. So u can read one complete word and check on each char, thats makes it more simple rather than complicating on these loops.

ssharish

[sifeet]

which compiler are you usinig?

I guess you were asking me, who started this thread. I use MinGW. and I write in Xemacs.
well. I still have the same problem. I removed scanf . and use only getchar.
I can not get the whole word from the player. Cause this is how the game is. computer randoms a word and the player tries to guess the word by guessing letters used in the word. so I have to have those loops!

[matsp]

printf("%s",word[index]);

This is broken - you are printing a single character as a string - you probably want %c instead of %s.

--
Mats