Thread: Beginner Help with returning a string of arrays

Hi al, Ive played with C like 5 or 6 years ago but i completely forgot how it works untill recently i'm doing it for a fun project. Anyway heres my code. randstr() will return a 6 char random string. I can printf the results on the randstr() functoin,but whenever i pass the value back to main() to be prinft. i get a lot of weird values. Englighten me!! thanks in advance

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>


char *randstr()
{

	char tempstr[6];
    char rnd;


    /* Set evil seed (initial seed) */
    srand( (unsigned)time( NULL ) );

    for (int i = 0; i < 6; i++) {
        rnd = ((float) rand()/RAND_MAX) * 25 + 97;
		tempstr[i] = rnd;
    }
    tempstr[6] = '\0';
//	printf("%s\n",tempstr);
    return tempstr;
}




int main()
{


printf("%s",randstr());
return 0;
}

thanks man! got it. you are from my to! u must be a C sifu

man .C is tough .. anyway why is this not working ?? why do i have to declare char login[50]; instead of char *login; ? what is the difference between both of them? i thought it's the same

Code:

char *randstr()
{

	static char tempstr[6];
    char rnd;


    /* Set evil seed (initial seed) */
    srand( (unsigned)time( NULL ) );

    for (int i = 0; i < 6; i++) {
        rnd = ((float) rand()/RAND_MAX) * 25 + 97;
		tempstr[i] = rnd;
    }
    tempstr[6] = '\0';
//	printf("%s\n",tempstr);
    return tempstr;
}




int main()
{
char *login;   <--- here 

	      strcpy(login,"NICK ");
		  strcat(login,randstr());
		  strcat(login," 8 * :abe abe\n");
		  printf("login var = %s",login);


return 0;
}

> for (int i = 0; i < 6; i++)
Standard C doesn't support declarations in for loops (C99, C++ and compiler specific extensions needed for this).

> tempstr[6] = '\0';
C array subscripts are from 0 to n-1, this is one off the end of the array.

> strcpy(login,"NICK ");
login isn't pointing anywhere - use an array, not a pointer
eg char login[100];

Originally Posted by yuliang11

thanks man! got it. you are from my to! u must be a C sifu

Sorry, I'm completely unable to decipher the last two sentences. What is your to? And what is a sifu?

1) "you are from my to! " = my ?

Yer location, Location: Kuala Lumpur, Malaysia ?


2 ) "sifu" = master (cantonese )

Sorry, yes, I asked a local and they told me what sifu meant. I'm not from KL, obviously, I just live here at the moment. :-)