Value comparison problem

**apokruphos** · 12-06-2005

Heyo. I've been bored at work and decided to brush up on my programming, but I'm hitting what appear to be a few pretty basic problems that I can't seem to fix. I'm trying to use an if statement to return different values depending on different values for passed character, ignoring case.

Here's how the function looks right now:

Code:

int CheckName(int x) {
  if (x == 'Q' || x == 'q')
    return -1;
  else if (x == ('c' || 'b' || 'h' || 'k' || 'm')) 
    return 1;
  else if (x == ('C' || 'B' || 'H' || 'K' || 'M'))
    return 1;
  else
    return 0;
}

The first if check works fine, but everything fails the following if statements and ends up returning 0. I have also tried:

Code:

int CheckName(int x) {
  if (x == 'Q' || x == 'q')
    return -1;
  else if (x == 'c' || 'b' || 'h' || 'k' || 'm') 
    return 1;
  else if (x == 'C' || 'B' || 'H' || 'K' || 'M')
    return 1;
  else
    return 0;
}

The only way I have gotten it to work is to have multiple checks within the parentheses, like the first if check, but it looks very large and overcomplicated. Is there a better way to do this?

**quzah** · 12-06-2005

Code:

if( x == this || x == that || x ==  theotherthing )

You have to do it that way, if you're going to use an if.

Quzah.

**apokruphos** · 12-06-2005

Bother. Is there a better way to check the variable against several different values? I prefer ifs to switch/case, but am drawing a blank as to any other options.

**quzah** · 12-06-2005

Is it really that hard to type three extra characters? (Five if you want to format it with nice little whitespaces.) But no, there isn't another way. Well, I take that back:

Code:

if( strchr( "cbhkmCBHKM", x ) )
{
    ...letter found...
}
else
{
    ...letter not found...
}

However, if you don't like function calls, use an 'if', or a 'switch'. But I'm sure there's someone else around here who taught god how to program, that will be along shortly to give you a better method. He seems to be stalking me, so he should be along shortly. (<--- sorry about that whole 'short' joke. Then again, I bet you are too.)

Quzah.

**apokruphos** · 12-06-2005

It's not a huge effort, just an aesthetic thing I suppose.

Code:

  else if (x == 'c' || x == 'b' || x == 'h' || x == 'k' || x == 'm')
    return 1;
  else if (x == 'C' || x == 'B' || x == 'H' || x == 'K' || x == 'M')
    return 0;

Just seems like it could be cleaned up a bit.

I don't mind function calls at all, that should work lovely. Thanks much.

**dwks** · 12-06-2005

tolower() might reduce your key strokes.

**quzah** · 12-06-2005

You could use tolower or toupper and then you'll only have to test for one case.

Quzah.

**dwks** · 12-06-2005

I already said that.

**quzah** · 12-06-2005

Ah, so you did. See what happens when you add Color to your posts? Insert something about cowboys, color, and being slow on the trigger here.

Quzah.

**Dave_Sinkula** · 12-06-2005

FWIW

Code:

int CheckName(int x)
{
   char text[2] = {0};
   text[0] = x;
   if ( strcspn(text, "Qq") == 0 )
   {
      return -1;
   }
   if ( strcspn(text, "CcBbHhKkMm") == 0 )
   {
      return 1;
   }
   return 0;
}

Thread: Value comparison problem

Thread Tools

Search Thread

Display

Value comparison problem

Similar Threads

Memory problem with Borland C 3.1

Someone having same problem with Code Block?

A question related to strcmp

WS_POPUP, continuation of old problem

Problem with comparison