Thread: custom header file can someone help?

Only put declarations in a header, not definitions.

What is this supposed to do?

Code:

#define employee

Are employee and employees supposed to be the same?

http://faq.cprogramming.com/cgi-bin/...&id=1043284385
http://www.daniweb.com/code/snippet278.html

Originally Posted by shaftinafrica

i know i should of used "gets" with the ClearInputBuffer function.

NOOOOOO!!! Follow the links.

Originally Posted by shaftinafrica

As far as employee and employees go i believe they are supposed to be the same.

And they are supposed to be a structure of some sort... passed as a parameter to the function? Before you reference the structure (like in a prototype)?

Whee. You need to back up a little bit.

For reading strings, see my previous links.
For reading numbers, see these links.

http://faq.cprogramming.com/cgi-bin/...&id=1043284385
http://www.daniweb.com/code/snippet266.html
http://www.daniweb.com/code/snippet357.html

Define the structure, something like this.

Code:

typedef struct employee{
	long ID;
	char FirstName[20];
	char LastName[30];
	double Salary;
	char StreetAddress[50];
	char City[30];
	char State[2];
	char ZipCode[10];
	char Telephone[13];
} employee;

Put that before your function definitions.

Move your code to a module rather than a header.

And then post again. That won't cure everything, but it's a start.

An overly large hint of a module that has no header:

Code:

#include <stdio.h>
#include <string.h>

char *mygetline(char *line, int size)
{
   if ( fgets(line, size, stdin) )
   {
      char *newline = strchr(line, '\n'); /* check for trailing '\n' */
      if ( newline )
      {
         *newline =  '\0'; /* overwrite the '\n' with a terminating null */
      }
   }
   return line;
}

long mygetli(long *result)
{
   char buff [ 13 ]; /* signed 32-bit value, extra room for '\n' and '\0' */
   return fgets(buff, sizeof buff, stdin) && sscanf(buff, "%ld", result) == 1;
}

int mygetd(double *result)
{
   char buff [ 32 ];
   return fgets(buff, sizeof buff, stdin) && sscanf(buff, "%lf", result) == 1;
}

typedef struct employee
{
	long ID;
	char FirstName[20];
	char LastName[30];
	double Salary;
	char StreetAddress[50];
	char City[30];
	char State[4];
	char ZipCode[10];
	char Telephone[13];
} employee;

employee CollectData(void)
{
   employee p;

   do {
      printf("Enter ID:");
      fflush(stdout);
   } while ( !mygetli(&p.ID) );

   printf("Enter first name:");
   fflush(stdout);
   mygetline(p.FirstName, sizeof p.FirstName);

   printf("Enter last name:");
   fflush(stdout);
   mygetline(p.LastName, sizeof p.LastName);

   printf("Enter the Street Address:");
   fflush(stdout);
   mygetline(p.StreetAddress, sizeof p.StreetAddress);

   printf("Enter the city:");
   fflush(stdout);
   mygetline(p.City, sizeof p.City);

   printf("Enter the state:");
   fflush(stdout);
   mygetline(p.State, sizeof p.State);

   printf("Enter the zipcode:");
   fflush(stdout);
   mygetline(p.ZipCode, sizeof p.ZipCode);

   printf("Enter the telephone number:");
   fflush(stdout);
   mygetline(p.Telephone, sizeof p.Telephone);

   do {
      printf("Enter the salary:");
      fflush(stdout);
   } while ( !mygetd(&p.Salary) );

   return p;
}

int main(void)
{
   employee e = CollectData();
   return 0;
}

/* my output
Enter ID:12345679
Enter first name:Dave
Enter last name:Sinkula
Enter the Street Address:123 Main St.
Enter the city:Anytown
Enter the state:XX
Enter the zipcode:54321
Enter the telephone number:123-4567
Enter the salary:1000000
*/

The State member could be smaller if it didn't work with my functions, but 2 is too small.

A bigger problem is that you don't know what a header file is supposed to do.

What is it that you think a header file should do?

A bigger problem is that you don't know what a header file is supposed to do.

1

shaftinafrica,
A header file should basically contain only function, structure and variable declaration and the other macros n typedefs.That means, the function prototypes, and not the actual function should be inside the header file. The convention is to write the function in a different library and then link the module during program execution.

Originally Posted by PING

A header file should basically contain only function, structure and variable definitions and the other macros n typedefs.That means, the function prototypes, and not the actual function should be inside the header file. The convention is to write the function in a different library and then link the module during program execution.

You've got all that right, but you've mixed up declaration and definition.

Originally Posted by c99:6.7p5

A declaration specifies the interpretation and attributes of a set of identifiers. A definition of an identifier is a declaration for that identifier that:

• for an object, causes storage to be reserved for that object;
• for a function, includes the function body;98)
• for an enumeration constant or typedef name, is the (only) declaration of the identifier.

Before you go too far, realize what we've been trying to say and understand that this stuff does not belong in the header:

Code:

void ClearInputBuffer()
{
	while(getchar() != '\n')
	      continue;
}
employee CollectData()
{
employee p;
	
	
	printf("Enter ID:");
	fflush(stdout);
	scanf("%ld", &p.ID);
	ClearInputBuffer();
	printf("Enter first name:");
	fflush(stdout);
	scanf("%s", &p.FirstName[20]);
	printf("Enter last name:");
	fflush(stdout);
	scanf("%s", &p.LastName[30]);
	printf("Enter the Street Address:");
	fflush(stdout);
	gets(&p.StreetAddress[50]);
	ClearInputBuffer();
	printf("Enter the city:");
	fflush(stdout);
	scanf("%s", &p.City[30]);
	printf("Enter the state:");
	fflush(stdout);
	scanf("%s", &p.State[2]);
	printf("Enter the zipcode:");
	fflush(stdout);
	scanf("%s", &p.ZipCode[10]);
	printf("Enter the telephone number:");
	fflush(stdout);
	scanf("%s", &p.Telephone[13]);
	printf("Enter the salary:");
	fflush(stdout);
	scanf("%lf", &p.Salary);
	return p;
}
void RaiseSalary(employee * p, int N, double PercentOfRaise)
{
	int i;
	for(i = 0; i < N; i++)
	{
		(p + i) -> Salary += ((p + i) -> Salary) * PercentOfRaise;
	}
}
employee FindHighestPaid(employee * p, int N)
{
	employee q;
	int i;
	q = *p;
	for(i = 1; i < N; i++)  
	{
		if(((p + i) -> Salary > q.Salary))
		{
			q = *(p + i);
		}
	}
	return q;
}
void DisplayEmployee(employee * p)
{
	printf("----------------------------------------------\n");
	printf("\t %s \t %ld \t %.2lf \t\n", p -> LastName, p -> ID, p -> Salary);
}

Forgive the C++ example, but something like this is how you're supposed to do it.

And if you're going to ignore the advice you get here, I'll just bow out of this thread.

[edit]And, by the way, these lines are wrong:

Code:

employee CollectData()
{
   employee p;


   printf("Enter ID:");
   fflush(stdout);
   scanf("%ld", &p.ID);
   ClearInputBuffer();
   printf("Enter first name:");
   fflush(stdout);
   scanf("%s", &p.FirstName[20]);
   printf("Enter last name:");
   fflush(stdout);
   scanf("%s", &p.LastName[30]);
   printf("Enter the Street Address:");
   fflush(stdout);
   gets(&p.StreetAddress[50]);
   ClearInputBuffer();
   printf("Enter the city:");
   fflush(stdout);
   scanf("%s", &p.City[30]);
   printf("Enter the state:");
   fflush(stdout);
   scanf("%s", &p.State[2]);
   printf("Enter the zipcode:");
   fflush(stdout);
   scanf("%s", &p.ZipCode[10]);
   printf("Enter the telephone number:");
   fflush(stdout);
   scanf("%s", &p.Telephone[13]);
   printf("Enter the salary:");
   fflush(stdout);
   scanf("%lf", &p.Salary);
   return p;
}

They all put data beyond where it is supposed to go.