Issues With Sorting Program

**dirtbiker** · 11-11-2005

I'm attempting to write a function to sort a series of values into asscending order:

Code:

void sort(float numbers[])       /* function to sort array */
{
        i = 0;
        while( i < (size) ) 
                {
                j = i + 1;
                while( j <= size ) 
                        {
                        if( A[i] > A[j] ) 
                                {
                                 temp = A[i];
                                 A[i] = A[j];
                                 A[j] = temp;
                                 }
                         j++;
                        } 
                i++;
                }
                for (i = 0; i < size; i++)        
    		    		printf("\nThe sorted x-values are: (%f)", A[i]); /* displays (x,y) cooridinates */
                        printf("\n");
}

Now, it compiles and runs fine but it seems to set the largest value in the array to zero and then re-order the values as it should. Any idea why it's doing that?

Many thanks,

Chris

**sahil_m** · 11-11-2005

First of all it's not a good idea to have global variables in your code when you dont need them to be global.Next your "j" counter is running up to size whereas it should have been size-1.

Here's an example on how I would go about writing that function:-

Code:

void sort(float array[],int size)
{
	int i,j;
	float temp=0;
	
	for(i=0;i<size;i++)
	{
		for(j=0;j<size;j++)
		{
			if(array[i] > array[j])
			{
				temp=array[i];
				array[i]=array[j];
				array[j]=temp;
			}
		}
	}
}

Make sure you fully understand how the above code works and why yours wont, try making a few hand-runs through the code that will make you see things clearer. Also learn how to use a debugger, the errors you are making can be easily caught if you know how to step through your code and watch variables.

Thread: Issues With Sorting Program

Thread Tools

Search Thread

Display

Issues With Sorting Program

Similar Threads

Continued issues with Winows Errors when running program

Need help with my program...

Dikumud

Sorting Program... :(

sorting output on student info program