function error

[jamez]

I've been fighting with this one for a little bit and I cant figure it out. The void printStudent(studentInfo); i've tried at printStudent(studentInfo *); and i've tried printStudent(studentInfo * stud); now I'm at this point where it compiles up to the fuction of printStudent(studentInfo * stud). I know this is such a simple fix that I'm missing it completely. Any ideas?

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define NUMELTS 10

struct student_info {
               char * firstname;
               char * lastname;
               char * major;
               char * yearinschool;
               int numcredits;
               float* gpa;
                    };

struct studentInfo * student_list;

void printStudent(studentInfo);
void printAllStudents();
void addStudent();
void getStudentInfo();

int main()
{
 char current = 'a';
 printf("Welcome to the student manager.\n");
 while (current != 'Q') 
  {
   printf("Enter a choice:\n");
   printf("[V]iew all students\n");
   printf("[A]dd a student\n");
   printf("[G]et info on a student.\n");
   printf("[Q]uit.\n");
   current = getc(stdin);

   getc(stdin);

   switch (current) 
   {
    case 'V':
      printAllStudents();
      break;
    case 'A':
      addStudent();
      break;
    case 'G':
      getStudentInfo();
      break;
    case 'Q':
      printf("Thank You!\n");
      getc(stdin);
      break;
    default:
      printf("Error: Unknown command!\n");
   }
  }
 return 0;
}
/************************** printstudent() **************************/
void printStudent(studentInfo * stud)
{
 printf("First: %s\n", stud->firstname);
 printf("\tLast: %s\n", stud->lastname);
 printf("\tMajor: %s\n", stud->major);
 printf("\tYear: %s\n", stud->yearinschool);
 printf("\tCredits: %d\n", stud->numcredits);
 printf("\tGPA: %f\n", stud->gpa);
}
/************************** printallstudents() **************************/
void printAllStudents()
{
 struct studentInfo * current = student_list;
  if (current != 0) 
   {
    while (current != 0) 
     {
      printStudent(current);
      current = current->next;
     }
    else 
     {
      printf("Error: No students have been entered yet!\n");
     }
   }
}
/************************** addstudent() **************************/
void addStudent()
{
 printf("Creating a new student...\n");
 studentInfo * temp = (struct studentInfo*) malloc(sizeof(struct studentInfo));
 printf("\nEnter student first name:");
 gets(temp->firstname);
 printf("\nEnter student last name:");
 gets(temp->lastname);
 printf("\nEnter the student's grade:");
 char buffer[8];
 gets(buffer);
 printf("\nEnter student major:");
 gets(temp->major);
 printf("\nEnter student year in school:");
 gets(temp->major);
 printf("\nEnter student credits:");
 gets(temp->numcredits);
 print("\nEnter student GPA:");
 gets(temp->gpa);
 printf("Adding student %s to the list...", temp->name);
 temp->next = student_list;
 student_list = temp;
 printf("Done!\n");
}
/************************** getstudentinfo() **************************/
void getStudentInfo()
{
 printf("Enter the name of a student:");
 char search[32];
 int found = 0;
 gets(search);
 printf("Searching the list...");
  struct studentInfo * current = student_list;
   while ((current != 0) && !found) 
    {
     if (!strcmp(current->name, search)) 
      {
       found = 1;
      }
     else
      {
       current = current->next;
      }
     printf("Done!\n");
     if (current != 0) 
      {
       printStudent(current);
      }
     else 
      {
       printf("No student by that name exists in the database\n");
      }
    }
}

[ZuK]

On top of the file you have declared the function to take a studentInfo as parameter

void printStudent(studentInfo);

and defined the function as

void printStudent(studentInfo * stud)

That takes a pointer to studentInfo as parameter. That are two different functions with the same name => error
Kurt

Btw what is studentInfo ?

guess you wanted to declare

struct studentInfo {
               char * firstname;
               char * lastname;
               char * major;
               char * yearinschool;
               int numcredits;
               float* gpa;
                    };

and further down in the code you are using studentInfo as a listnode but studentInfo has no next pointer.

Found some more

 studentInfo * temp = (struct studentInfo*) malloc(sizeof(struct studentInfo));
 printf("\nEnter student first name:");
 gets(temp->firstname);

You have never allocated any space for temp->firstname and any of the other strings in studentInfo.
Kurt

[jamez]

I've tried the void as:

void printStudent(studentInfo *);

and:

void printStudent(studentInfo * stud);

and I've gotten an error on compile everytime until I changed it and dropped the *. This should point to the print for studentInfo. student_info is actually the name of the struct. the malloc hasn't generated a compile error, I guess, since I haven't gotten past this point.

I've tried to format the void differently, but I'm not having any luck at that either.

[ZuK]

Let me tell you again. The compiler doesn't know what a studentInfo is ( you called the struct student_info ).
Kurt

[spydoor]

I hesitate to post this because it is still full of errors, but hopefully will get you closer.

you must always use the keyword struct since you never typedef your struct.

You have no space to store any data in firstname, lastname...
to start I'd change those to char firstname[100] and so on. Then change to dynamic memory allocation later.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define NUMELTS 10

struct studentInfo {
               char * firstname;
               char * lastname;
               char * major;
               char * yearinschool;
               struct studentInfo *next;
               int numcredits;
               float* gpa;
            };

struct studentInfo * student_list;

void printStudent(struct studentInfo*);
void printAllStudents();
void addStudent();
void getStudentInfo();

int main()
{
 char current = 'a';
 printf("Welcome to the student manager.\n");
 while (current != 'Q')
  {
   printf("Enter a choice:\n");
   printf("[V]iew all students\n");
   printf("[A]dd a student\n");
   printf("[G]et info on a student.\n");
   printf("[Q]uit.\n");
   current = getc(stdin);

   getc(stdin);

   switch (current)
   {
    case 'V':
      printAllStudents();
      break;
    case 'A':
      addStudent();
      break;
    case 'G':
      getStudentInfo();
      break;
    case 'Q':
      printf("Thank You!\n");
      getc(stdin);
      break;
    default:
      printf("Error: Unknown command!\n");
   }
  }
 return 0;
}
/************************** printstudent() **************************/
void printStudent(struct studentInfo * stud)
{
 printf("First: %s\n", stud->firstname);
 printf("\tLast: %s\n", stud->lastname);
 printf("\tMajor: %s\n", stud->major);
 printf("\tYear: %s\n", stud->yearinschool);
 printf("\tCredits: %d\n", stud->numcredits);
 printf("\tGPA: %f\n", stud->gpa);
}
/************************** printallstudents() **************************/
void printAllStudents()
{
 struct studentInfo * current = student_list;
  if (current != 0)
   {
    while (current != 0)
     {
      printStudent(current);
      current = current->next;
     }
   }
    else
     {
      printf("Error: No students have been entered yet!\n");
     }
}
/************************** addstudent() **************************/
void addStudent()
{
 printf("Creating a new student...\n");
 struct studentInfo * temp = (struct studentInfo*) malloc(sizeof(struct studentInfo));
 printf("\nEnter student first name:");
 gets(temp->firstname);
 printf("\nEnter student last name:");
 gets(temp->lastname);
 printf("\nEnter the student's grade:");
 char buffer[8];
 gets(buffer);
 printf("\nEnter student major:");
 gets(temp->major);
 printf("\nEnter student year in school:");
 gets(temp->major); // major twice ???
 // Can't use gets with int
 //printf("\nEnter student credits:");
 //gets(temp->numcredits);
 //print("\nEnter student GPA:");
 //gets(temp->gpa);
 printf("Adding student %s to the list...", temp->name);
 temp->next = student_list;
 student_list = temp;
 printf("Done!\n");
}
/************************** getstudentinfo() **************************/
void getStudentInfo()
{
 printf("Enter the name of a student:");
 char search[32];
 int found = 0;
 gets(search);
 printf("Searching the list...");
  struct studentInfo * current = student_list;
   while ((current != 0) && !found)
    {
     if (!strcmp(current->name, search))
      {
       found = 1;
      }
     else
      {
       current = current->next;
      }
     printf("Done!\n");
     if (current != 0)
      {
       printStudent(current);
      }
     else
      {
       printf("No student by that name exists in the database\n");
      }
    }
}

[dwks]

1. Don't use gets(). It's dangerous. See the FAQ.
2. You shouldn't cast malloc(). See the FAQ.
3. This code

   getc(stdin);

   is the same as getchar(). Actually, to flush the input buffer, you should use
   

   int c;
   while((c = getchar()) != '\n' && c != EOF);

4. You know that declaring variables in the middle of blocks
   

    printf("\nEnter the student's grade:");
    char buffer[8];
    gets(buffer);

   is C99/C++?

[jamez]

Sorry. I was either blind or not understanding. I've got that fixed, but now I'm getting an error in my struct that visual studio points out at:

int numcredits;

[jamez]

dwks:

I'm looking over the FAQ right now. Thanks for the heads up on that and I wasn't aware I put c++ in there. I'll have to take that out to keep from confusing myself. I saw up all night working on it because of other pressing issues. Thanks for all the help from everyone. It's greatly appreciated.

[spydoor]

Sorry. I was either blind or not understanding. I've got that fixed, but now I'm getting an error in my struct that visual studio points out at:

int numcredits;

No one is going to be able to help with just that info.
post at least your entire struct declaration and the error message

[SlyMaelstrom]

No one is going to be able to help with just that info.
post at least your entire struct declaration and the error message

... he has the entire program posted. Look in his structure.