Newbie in problem with looping

**nrain** · 11-04-2005

hii all,

i am a total newbie here and also a BRAND NEW learner of C

as a part of my first assignment in class i have done the following
coding. but having problem wth this. is there any one who wishes
to help me??

Code:

#include <stdio.h>			

void main()

{

char line;          

clrscr();

printf("Choose your initial state:");

line=getchar();

    switch(line)    {
		case '1': 
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");

		case '2':
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");

		case '3':
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");

		case '4':
		printf("Step 4:\t L==Green\t\t\tRed\n");

		case '5':
		printf("Step 5:\t L==Amber\t\t\tRed\n");

		case '6':
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		}
        getch();
}

My problems are:
1. I want to use looping , but unfortunately both while and for loops are failed.
2. I want to run the loops depending on user demand.

Is there any 1 to help this newbie???

JUST TELL ME IF I NEED TO PRACTICE OR ADD ANY SPECIFIC FUNCTION

IF Any 1 can suggest any good pdf to learn switch & loops with example, I will be grateful

**Happy_Reaper** · 11-04-2005

I don't particularly see why you would want loops in there. That is, unless you want to cycle through the steps. What specifically is it that you're trying to do ?

And as for ressources on learning about loops and switch statements :

For loops :
http://www.cprogramming.com/tutorial/c/lesson3.html

For switch statements :
http://www.cprogramming.com/tutorial/c/lesson5.html

**dwks** · 11-04-2005

And main() should return int.

**nrain** · 11-05-2005

would any1 plz find an error that is causing LOOP-error

Code:


#include <stdio.h>
#include <conio.h>
void main()
{

char line;

for(line=0;line<7;line++){
   printf("Choose your initial state:");
   line=getchar();

   switch(line)
		{
		case '1':
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		printf("Step 4:\t L==Green\t\t\tRed\n");
		printf("Step 5:\t L==Amber\t\t\tRed\n");
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Choose your initial state:");
		scanf("%d",&line);
                break;

		case '2':
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		printf("Step 4:\t L==Green\t\t\tRed\n");
		printf("Step 5:\t L==Amber\t\t\tRed\n");
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Choose your initial state:");
		scanf("%d",&line);
		break;

		case '3':
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		printf("Step 4:\t L==Green\t\t\tRed\n");
		printf("Step 5:\t L==Amber\t\t\tRed\n");
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		break;

		case '4':
		printf("Step 4:\t L==Green\t\t\tRed\n");
		printf("Step 5:\t L==Amber\t\t\tRed\n");
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		break;

		case '5':
		printf("Step 5:\t L==Amber\t\t\tRed\n");
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		printf("Step 4:\t L==Green\t\t\tRed\n");
		break;

		case '6':
		printf("Step 6:\t L==Red\t\t\t\tRed+Amber\n");
		printf("Step 1:\t L==Red\t\t\t\tGreen\n");
		printf("Step 2:\t L==Red\t\t\t\tAmber\n");
		printf("Step 3:\t L==Red+Amber\t\t\tRed\n");
		printf("Step 4:\t L==Green\t\t\tRed\n");
		printf("Step 5:\t L==Amber\t\t\tRed\n");
	
		default:
		printf("Choose your initial state:");
   		line=getchar();
                break;            

		}
		continue;
                }
		 


}

**ZuK** · 11-05-2005

The statement

Code:

line = getchar();

inside the for-loop overwrites the value of line in the for-loop. Use different variables.
Kurt

**dwks** · 11-05-2005

And main() should return int!

Change this

Code:

void main() {
    /* ... */
}

to

Code:

int main() {
    /* ... */
    return 0;
}

Your default case doesn't do what you think it does. And you don't need continue at the end of the for loop. Nor <conio.h>.

**cbastard** · 11-05-2005

Your case '6' does'nt contain a break statement but that will not give you a loop error.
Take another int variable for for loop.as already told.

Thread: Newbie in problem with looping

Thread Tools

Search Thread

Display

Newbie in problem with looping

still prob

Similar Threads

Structure Array Looping Problem

Problem with looping.

newbie Windows problem...

Looping Problem

newbie coding problem