Thread: Circular doubly linked list with dummy header

Probably because main doesn't return void. Or it could be because that's horrible code. It's ugly to read, and it's a lousy implementation. Oh, and you're one of those people who for some reason thinks it's a good idea to typedef pointers.


Quzah.

Code:

pA->Rnext = pB->Lnext;

The above line copies the pointer contained on pB->Lnext to the pointer pA->Rnext. When this line is executed, the pointer pB->Lnext is uninitialized, containing any random address. That means that pA->Rnext will also contain the same random address.

To further complicate matters, two lines down pB->Lnext is set to the value of pA->Rnext, which is just a useless because neither pointer has been initialized to any valid address.

Code:

pA->Rnext = pB->Lnext;
pB->Lnext = pA->Rnext;

This whole mess can be corrected by setting the Lnext and Rnext pointers to valid addresses of struct node objects. If you want pA->Rnext to point to pB, then do that

Code:

pA->Rnext = pB;

Oh, and you're one of those people who for some reason thinks it's a good idea to typedef pointers.

Code:

struct node
{
       int data;
       struct node *next;
};

typedef struct node * nodeptr;

Why is the above code a bad idea, besides the obvious pitfall:-

Code:

nodeptr p;
p=malloc(sizeof(nodeptr));

If you think that it reduces readability I beg to disagree, I think the contrary.

Well for starters, I never have to go searching through whatever header file you've burried your typedef in to see what p really is, if I see this line instead:

Code:

struct foo *p;

Secondly, I find it to be very ugly. It's probably one of the reasons I've never felt the desire to do Windows programming. They have this need to typedef EVERYTHING. So annoying, and very ugly code.

I suppose it's all well and good if you like to typedef them. It's your code after all. Just don't expect me to read it unless I'm being paid.


Quzah.

It would be really nice if you read http://cboard.cprogramming.com/showthread.php?t=71094 this code of mine, though I dont think I could pay you