Thread: loops in a main statement....

Hello, all...

I have a program and what it is trying to do is read in an outside file and take the 3 numbers in the files to read into row, columns, and colors. So it's something like 2 G B... 2 for the row, G for the column and B for black (there is black and white).

I have all my functions working properly, I think. But the problem I am having is with my main statement and calling the functions properly. I've been fiddling around with/trying to get this part to work for about 2 hours and I'm just getting really frustrated, so I figured maybe I can get some help.

so here is what I got so far...

Code:

     
#include<stdio.h>
#define sentinel 100 X X

void drawVert(char lastcol);
void drawToStone(char curcol, char stonecol); 
void drawStone(char stonecol, char lastcol, char color);
void drawRestOfRow(char curcol, char lastcol);
void drawEmptyRow(char lastcol); 

int main(void)
{
	FILE* myin;
	char column;
	char lastcol='H';
	char curcol='A';
	char stonecol;
	int stonerow;
	int currow;
	char color;

	myin=fopen("fewstones.txt","r");
	fscanf(myin, "%d %c %c", &stonerow, &stonecol, &color);

	for (currow=1; currow<=8; currow++)
	{
		
		if (currow != stonerow || curcol != stonecol)
			drawEmptyRow(lastcol);
		if (currow != 8)
			drawVert(lastcol);

		else
		{
			while (stonerow == currow)
			{
				drawToStone(curcol,lastcol);
				drawStone(stonecol,lastcol,color);
			}
			if (curcol !=lastcol)
				drawRestOfRow(curcol, lastcol);	
			
			curcol = stonecol + 1;
			fscanf(myin, "%d %c %c", &stonerow, &stonecol, &color);
		}
	}
	return(0);
}

void drawVert(char lastcol)
{
	char column='A';


	for(column='A'; column<=lastcol; column++)
		printf("|   ");
	printf("\n");

	for(column='A'; column<=lastcol; column++)
		printf("|   ");
	printf("\n");
}

void drawToStone(char curcol, char stonecol)
{
	for(curcol; curcol<stonecol; curcol++)
	{
		if(curcol == 'A')
			printf("---");
		else if(curcol == 'H')
			printf("--");
		else
			printf("----");
	}
}

void drawStone(char stonecol, char lastcol, char color)
{
	if(stonecol == 'A')
		printf("%c%c-", color, color);
	else if(stonecol == lastcol)
		printf("%c%c", color, color);
	else	
		printf("%c%c%c-", color, color, color);
}

void drawRestOfRow(char curcol, char lastcol)
{
	for(curcol; curcol<lastcol; curcol++)
	{
		printf("----");
	}
	if(curcol==lastcol)
		printf("--");
}

void drawEmptyRow(char lastcol)
{
	char column;
	for(column='A'; column<lastcol; column++)
		printf("----");

	printf("-\n");
}

If someone can help me out and steer me in the right direction, or tell me even if I am going in the right direction that would be great!! If you want to know what the program is exactly doing, I put it briefly, I can explain more...... At this point I have lost hope and am just outright confused..... Please show me the light... thank you.

-Ricky

Your major problems seem to lie in this region:

Code:

while (stonerow == currow)
			{
				drawToStone(curcol,lastcol);
				drawStone(stonecol,lastcol,color);
			}
			if (curcol !=lastcol)
				drawRestOfRow(curcol, lastcol);	
			
			curcol = stonecol + 1;
			fscanf(myin, "%d %c %c", &stonerow, &stonecol, &color);

Take a look at the while statement there, besides the fact that stonerow HAS to be 8 for it to work(from your if-else statement) the while loop will never end. If stonerow is 8 then it will go on forever because stonerow will always equal currow, unless you change it, and you don't.

Code:

void drawRestOfRow(char curcol, char lastcol)
{
	for(curcol; curcol<lastcol; curcol++)
	{

That code is pointless.

Code:

if (currow != 8)
    drawVert(lastcol);
else ///////////IF CURROW == 8(Only the 8th column is drawn?)
{
                while (stonerow == currow)
	{
		drawToStone(curcol,lastcol);
		drawStone(stonecol,lastcol,color);
	}
	if (curcol !=lastcol)
		drawRestOfRow(curcol, lastcol);	
			
	curcol = stonecol + 1;
	fscanf(myin, "%d %c %c", &stonerow, &stonecol, &color);
}

you really need to visualize what you are trying to do and write the correct logic from that. Debugging and stepping through to watch the values change might help you also. A simple row/column algorithm could be done as an O^2 algorithm. For Example:

Code:

for( int i=0; i<numRows; i++ )
{
   printf("Row %d: ", i);
   for( int j=0; i<numCols; i++ )
   {
       //Do your checks here ie. Empty column
       //You could even read from the file here
       printf("%d   ", YourData[i][j]);
   }
   printf("\n");
}

Of course, your version could work. C++ comes with the functionality to do everything 135124 ways.

Code:

for(curcol; curcol<lastcol; curcol++)

that syntax is correct, the real reason it doesn't work is because you can't iterate through a single char.

I agree it is the same. Pff your right, you can iterate a char. Its getting late hehe. I was thinking about iterating data that was already set like an array. I've been working with network headers for weeks now and it got drilled into my head that I couldn't go outside of the data range heh.