strange output

[ssharish2005]

hai everyone, i have been in a small confusion, can any one correct me please. the follwing programe dosn't output more than 3 char

#include<stdio.h>
char upcase(char []);

int main()
{
    char str[25];
    
    printf("Enter a string\n?");
    fgets(str,sizeof(str),stdin);
    upcase(str);
    getchar();
}

char upcase(char *p)
{
    static int i=0;
    
    if(*(p+i)=='\0')
    return;
    else
    {
         printf("%c",*(p+i)-32);
    return upcase(p+i++);
   
}    
}

can any one tell me whats going worng in the code and please correct me please

[bithub]

The problem is that you are incrementing the value of i each call, and incrementing the value of p. This means you are exponentially iterating through the string skipping most of the characters. Either stop incrementing i, or stop incrementing p.

For instance:

char upcase(char *p)
{
    static int i=0;
    
    if(*(p+i)=='\0')
		return;
    else
    {
        printf("%c",*(p+i)-32);
		i++;
		return upcase(p);
   
	}    
}

Also keep in mind you are likely to have a '\n' at the end of your string. You don't want to try and turn that into an uppercase letter.

[ssharish2005]

thax very much bithub i got it right