Thread: neverending loop

Hey guys i have the following code it reads a text file and list numbers to each word line. example:

1. abfdfd
2. hello world
3
4 so on..

but at the moment its only listing the numbers and in a neverending loop so i have no idea whats going on.

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char **argv)
{

    int line_no = 0;
    int input_char = 0;
    int nl = 0;
    FILE *fp;

    if(argc !=2) /* check for 2 arguments*/
    {

      fprintf(stderr, "invalid usage :%s\n", argv[0]);
      return 1; /* stop processing if failes */

    }

    if((fp = fopen(argv[1], "r")) == NULL) 
    /* opens file for reading and checks if it exists */
    {
     
     fprintf(stderr, "invalid usage: %s\n", argv[0]);
     return 1; /* stop processing if fails*/

    }


      while(input_char !=EOF)
 
          /* keep asking for input while not end of file*/
      {
          if ( nl )
          {
             printf("\n%d ", line_no);
             line_no++;
	  }
	  else
          { 
	     putc(input_char, stdout);
	     input_char = getc(fp);   
	     nl = input_char == '\n';
          }
    }
       
    

    fclose(fp);



    return EXIT_SUCCESS;

}

Ok yehhhh i did intialize it to zero but why does it still loop

No, you need to set it to 0 here:

Code:

if ( nl )
{
    printf("\n%d ", line_no);
    line_no++;
    nl = 0;
}

Otherwise as soon as you hit the first newline, it will be permantly stuck in the "found a new line" state.

You are doing that the hard way. use fgets() and you don't have to worry about EOF.

Code:

char line[255];
int line_counter = 1;
while(fgets(line,sizeof(line),fp) != 0)
{
   printf("%d%s", line_counter++,line);
}

hi bazzano,

here is the solution for ur ques. im new to this website and to file handling. i have solved it with watever i know.
hope u like it.

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char **argv)
{

    int line_no = 1;
    char input_char;
    FILE *fp;
    clrscr();
    if(argc !=2) /* check for 2 arguments*/
    {

      fprintf(stderr, "invalid usage :%s\n", argv[0]);
     return 1; /* stop processing if failes */

    }

    if((fp = fopen(argv[1],"r")) == NULL)
    /* opens file for reading and checks if it exists */
    {

     fprintf(stderr, "invalid usage: %s\n", argv[0]);
     return 1; /* stop processing if fails*/

    }
     printf("\n%d. ", line_no);
     while(input_char!=EOF)
	  /* keep asking for input while not end of file*/
      {
      input_char = getc(fp);
      if(input_char=='\n')
	  {
	  line_no++;
	  printf("\n%d. ", line_no);
	  }
	     if(input_char!='\n')
	     putc(input_char, stdout);

    }
       printf("\b\b\b\b  \b\b");
    fclose(fp);
   return EXIT_SUCCESS;
}