Error

**Kaho** · 08-18-2005

I got my first program to work but it has a little bug in it.

What Could be the problem? would i need a few more printfs?

Here the code:

Code:

#include <stdio.h>

int main()

{
   int a, b, c, d;
   
   printf( "Please enter five numbers between 1 and 10\n" );
   scanf( "%d", &a,&b,&c,&d); /* sets the numbers u inputed */
   if ( a== 1 || b == 1 || c == 1 || d == 1 || a == 2 || b == 2 || c == 2 || d == 2 || a == 3 || b == 3 || c == 3 || d == 3 || a == 4 || b == 4 || c == 4 || d == 4 || a == 5 || b == 5 || c == 5 || d == 5 ) {
        printf( "Wow your as smart as me\n" );
       
        }
       
        else if (a == 6 || b == 6 || c == 6 || d ==6 || a == 7 || b == 7 || c == 7 || d == 7 || a == 8 || b == 8 || c == 8 || d == 8 || a == 9 || b == 9 || c == 9 || d == 9 || a == 10 || b == 10 || c == 10 || d == 10 ) {
              printf( "WOW You smarter than me\n" );
             
              }
              else {
                    printf( "OMFG u thought of %d, %d, %d, %d\n", a, b, c, d );
                    }
                   
                    system("pause");
                    return 0;
                   
                    }

**Tonto** · 08-18-2005

Code:

int main()
{
	int a,b,c,d;
	
	printf("Enter 4 space seperated numbers: ");
	scanf("%d %d %d %d", &a, &b, &c, &d);

        // Do some stuff with a b c d here

	printf("You entered: %d %d %d %d\n", a, b, c, d);
	return 0;
}

Random values from somewhere off the stack or something are being stuffed into b, c, d using your code. You need to provide a proper format string to scanf for what you want, which would be "%d %d %d %d". You might find this MSDN entry somewhat interesting: http://msdn.microsoft.com/library/de...2c_.wscanf.asp

**Kaho** · 08-18-2005

Oh Thank u i was looking into that last night but i was looking at something else

**grumpy** · 08-18-2005

Tonto gave the correct solution, but his explanation of what was happening in the original code is incorrect. The scanf() call is only reading one value (the first of the four you input), and putting it into the variable a. The other variables are never initialised, so contain junk and are never modified by the scanf() call.

**Salem** · 08-19-2005

> printf( "Please enter five numbers between 1 and 10\n" );
> scanf( "%d", &a,&b,&c,&d); /* sets the numbers u inputed */
How about learning to count?
You ask for 5
You have 4 variables
You scanf for just one one them

**Kaho** · 08-19-2005

Originally Posted by Salem

> printf( "Please enter five numbers between 1 and 10\n" );
> scanf( "%d", &a,&b,&c,&d); /* sets the numbers u inputed */
How about learning to count?
You ask for 5
You have 4 variables
You scanf for just one one them

Its all fixed and about the coutning issue i ment four but i hit 5 instead i was a little tired and didnt know what i was suppose to be doing.

But anyways its all good now

Thread: Error

Thread Tools

Search Thread

Display

Error

Similar Threads

Getting an error with OpenGL: collect2: ld returned 1 exit status

An error is driving me nuts!

Making C DLL using MSVC++ 2005

Connecting to a mysql server and querying problem

Couple C questions :)