Thread: Help! Programming Problem

I'm learning how to program with C and I have a problem that I have never had before and don't know how to solve. I hope someone will be able to help me out.
I did this program:

PHP Code:

 #include <stdio.h>
int findMax(int[], int ); /* prototype*/
int main()
{
int nums [10][20], i, j;
for (i=0; i < 200; ++i);
for (j=0; i < 200; ++j);
nums[i][j] = 2*i; 
printf("The maximum value is %d \nin row $i column $j", findMax(*nums, 200), i, j);
return 0;
}
int findMax(int vals[], int numEls) /*find the maximum value*/
{
    int i, *nums, max = vals [0];
    for (i=1; i < 200; ++i);
    if (max,vals[i])
       max = vals[i];
       
    return(max);
} 


When I run debug on my complier it gives me the following message that I have never encountered before:

PHP Code:

Windows has triggered a breakpoint in Assignment 4A-2-a.exe.

This may be due to a corruption of the heap, and indicates a bug in Assignment 4A-2-a.exe or any of the DLLs it has loaded.

The output window may have more diagnostic information 


I understand that I must have something not completely right but can't figure out what? COuld you guys help me out.
Thanks.

Quzah, the example I based my program on was saying:

PHP Code:

for (i = 1; i<numEls; ++i, ++vals) 


So I assumed numEls was the number of elements. In a 10-by-20 I counted 200.

But I'll try with what you gave me.

Thanks.

And what is this?

Code:

printf("The maximum value is %d \nin row $i column $j", findMax(*nums, 200), i, j);

The format string for the call to printf() specifies one argument, yet you are passing three.

Kermit,

I want the result to display the following answer:

The maximum value is .... in row .... column ....

So it gives me in which row and column the answer is.

Originally Posted by quzah

Oh, but wait, there's more! I actually just stopped at the first error. Like your compiler. But looking further...

Code:

 for (i=1; i < 200; ++i);
    if (max,vals[i])

Which really gives you this:

Code:

if( max )

Of course, that's after it tries to access vals[200]...


Quzah.

IIRC you use gcc, right? Mine says this

Code:

find_max.c:16: warning: left-hand operand of comma expression has no effect

I was thinking this meant that it used vals[i] and not max?

Originally Posted by flicka

Kermit,

I want the result to display the following answer:

The maximum value is .... in row .... column ....

So it gives me in which row and column the answer is.

Does it? That's funny - not on my machine...

Quzah,

Ok I get the picture but even if I change 200 and put:

int nums [10][20], i, j;
for (i=0; i < 9; ++i);
for (j=0; i < 19; ++j);
nums[i][j] = 2*i;

I still get the same "break" message on the compiler.

doesn't

nums[i][j] = 2*i;

mean assigne the value 2*i to the number in row 1, column j?

I'm starting to get more lost now than before...

Kermit,

I'm using Microsoft Visual C++.
This is what I get:

HEAP[Assignment 4A-2-a.exe]: HEAP: Free Heap block 132f78 modified at 133ad0 after it was freed
Windows has triggered a breakpoint in Assignment 4A-2-a.exe.

This may be due to a corruption of the heap, and indicates a bug in Assignment 4A-2-a.exe or any of the DLLs it has loaded.

The output window may have more diagnostic information
The program '[832] Assignment 4A-2-a.exe: Native' has exited with code 0 (0x0).

but when I click on continue it does give me a value. it is just that I have to click on continue which I wish not to have to.

bigtamscot

Yes I'm just starting out and it'sa not always easy. I think I'm so affraid to forget the semi colons that I put some everywhere.

Thanks for your help.

Kermit,

I did a similar program with a single array, but since it was a simple array I defined the array with numbers:

PHP Code:

int main() 
{ 
int nums[5] = {2, 18, 1, 27, 16}; 
printf("The maximum value is %d", findMax(nums,5)); 
return 0;
} 


Now I am trying to pass into to a 2d array. Should I do the same thing and define all the numbers in the array?? or can I define it the way I was?