Thread: Converting char* to char**

Whilst they may satisfy the type system, you have to look at the context of what the code is actually going to do with that pointer.
If it's expecting to write some value (to a char*), then the &myvar call is correct.

Eg.

Code:

void foo ( char **p ) {
  *p = malloc(10);
}
int main ( void ) {
  char *q;
  char **bad;  // not pointing anywhere
  foo ( &q );
  // q now points to 10 bytes of memory (or NULL)
  foo ( bad );  // type is OK, but the pointer gets written to somewhere you don't want it
  return 0;
}

If you don't have the code, then read the manual page on how to use the function.
If you don't have that, then you're stuck.

Like I said, there are several syntactically valid ways of passing a parameter, but unless you know which one you're supposed to use, it's just not going to work.

Are you suggesting that
char *foo = GenerateHash( argv, "hello" );
is an acceptable way of calling the function?

more like:

Code:

int main( int argc, char **argv )
{
    char *strEncryptedKey;
    char **ppHashElements;
    char *strHashValue;
    int rc = 0;

    if ( argc < 3 )
    {
        fprintf( stderr, "Usage:  TestHash encryptedKey hashElement...\n" );
        return 1;
    }

    strEncryptedKey = argv[ 1 ];
    ppHashElements = &argv[ 2 ];

    strHashValue = GenerateHash( ppHashElements, strEncryptedKey );

That works perfectly...


And here what I'm tryin to do:

Code:

PHP_FUNCTION(hsbc_cpi_make_hash)
{

    char *strEncryptedKey;
    int  strEncryptedKey_len;
    zval *arr, **data;
    HashTable *arr_hash;
    HashPosition pointer;
    char *ppHashElements;
    char *strHashValue;
    int  rc=0;
    int array_count;
    int count = 0;
    int bcount = 0;

   if ( zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "as", &arr, &strEncryptedKey, &strEncryptedKey_len) == FAILURE ) {
	RETURN_NULL();
     }

    arr_hash = Z_ARRVAL_P(arr);
    array_count = zend_hash_num_elements(arr_hash);

    ppHashElements = malloc(2048);
    if(!ppHashElements){
	RETURN_NULL();
    }

   memset(ppHashElements, 0, 2048);

   for(zend_hash_internal_pointer_reset_ex(arr_hash, &pointer);
   zend_hash_get_current_data_ex(arr_hash, (void**) &data, &pointer) == SUCCESS;
   zend_hash_move_forward_ex(arr_hash, &pointer)){
	
	count++;
	zval temp;
	temp = **data;
	zval_copy_ctor(&temp);
	convert_to_string(&temp);
        strcat(ppHashElements, Z_STRVAL(temp));
        if(count < array_count){
	    strcat(ppHashElements, ", ");
	}
	zval_dtor(&temp);
    }

    strHashValue = GenerateHash(&ppHashElements, strEncryptedKey );

    php_printf("%s\n", strEncryptedKey);
    php_printf("%s\n", strHashValue);
    php_printf("%s\n", ppHashElements);

    free(ppHashElements);

    if(!strHashValue){
        RETURN_FALSE;
    }
 
    RETURN_STRING(strHashValue, 1);

}

Code:

char *args[2];
args[0] = yourstring;
args[1] = NULL;

GenerateHash( args, foo );

Now you have in effect a duplicate of whatever you say "works perfectly".


Quzah.