How to get the number of lines in a file
Hi all...
How can I get the numer of lines in a file ?
A solution is:
char string[20
int counter = 0;
f = fopen ("blabla.txt", "r");
while (fscanf(f, "%s", string)>0) counter++;
But.. is there a better solution ? one which doesn't waste memory allocating a variable ?
PS:
while (fscanf(f, "%*s")>0) counter++; doesn't work
PPS: I'm Using Borland C++ Builder
Thx in advance
Well first off, your answer wouldn't work right even if it did compile. All it does is count "words". If it didn't run off the end of the buffer and crash your program, it still wouldn't give the right answer.
Read a character at a time. Test the character to see if it's the newline character. If it is, you've reached the end of a line. Repeat until you find the end of the file. While you're at it, go read the EOF FAQ.
Quzah.
Hope is the first step on the road to disappointment.
How about (untested):
Code:while (!feof(fin)){ if (fgetc(fin) == '\n') lineCount++; }
Free code: http://sol-biotech.com/code/.
It is not that old programmers are any smarter or code better, it is just that they have made the same stupid mistake so many times that it is second nature to fix it.
--Me, I just made it up
The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore, all progress depends on the unreasonable man.
--George Bernard Shaw
Then how about that line be
Code:lineCount += (fgetc(fin) == '\n')
How about reading the feof FAQ to see why your answer is wrong?Originally Posted by mitakeet
Quzah.
Hope is the first step on the road to disappointment.
well.. yes.. i already know how my file is formatted (one string per line)... however it's better to code a general case, which will work for every case
_________________________________________________
works... and obviously the mitakeet one tooCode:while (!feof(f)){ counter += (fgetc(f) == '\n'); }
Thx a lot guys
Cya
Last edited by delphi; 07-14-2005 at 05:48 AM.
Consider reading the FAQ on how to get a line from the user. You're not seeing the point here: %s stops at white space. A "string" in C is a series of characters terminated by a newline. By definition then, it could include spaces. You don't say if your file has spaces other than the newlines at the end of the file. If you do, then %s isn't going to read the whole line. Likewise, if any of your "strings" is longer than your array size (including room for the null), you can crash your program.
At any rate, you may want to visit the FAQ anyway.
Quzah.
Hope is the first step on the road to disappointment.
well.. ok.. feof shouldn't be used.. then i can use this
Code:char c; while ((c = fgetc(f))!=EOF){ count += (c == '\n'); }
Nope. Some one didn't read the EOF FAQ like I suggested.
On an aside, it'd likely be more efficient to test seperately from incrementing so you don't bother adding 0 over and over. Faster to check and if true increment, than to test and add for every character.
Quzah.
Hope is the first step on the road to disappointment.
Since i'm noob.. could u write the best code in your opinion :O
char c;
is it ok now ?Code:while ((c = fgetc(f))!=EOF){ if (c=='\n') count++; }
Nope. Someone still didn't read the EOF FAQ.Code:char c;
Quzah.
Hope is the first step on the road to disappointment.
Care to explain to a dense 10 year professional programmer how my code is wrong? Your FAQ doesn't tell me how my code is flawed.
Free code: http://sol-biotech.com/code/.
It is not that old programmers are any smarter or code better, it is just that they have made the same stupid mistake so many times that it is second nature to fix it.
--Me, I just made it up
The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore, all progress depends on the unreasonable man.
--George Bernard Shaw
I guess a "10 year professional" can't read.
Quzah.
Hope is the first step on the road to disappointment.
I have in fact read your FAQ and I see nothing that changes my mind. Care to point out where I am so wrong, you being so smart and all?
Free code: http://sol-biotech.com/code/.
It is not that old programmers are any smarter or code better, it is just that they have made the same stupid mistake so many times that it is second nature to fix it.
--Me, I just made it up
The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore, all progress depends on the unreasonable man.
--George Bernard Shaw
