An assignment I'm currently doing required me to round of a float. I didn't know if there was a standard function for it or not, (if there is I couldn't find it) so I wrote my own.
It works fine but I'm just seeing what people have to say about it. Maybe some tips on improvment.Code:int round(float x){ int y = (int)x; if((x - y) > 0.5f){ x = (float)++y; } else{ x = (float)y; } return (int)x; }
why are you casting y to a float before assigning it to x? and why are you returning x?
why not just increment or decrement y and return it?
and the answer to your standard function question: kinda. ther's ceil(x) and floor(x). you can probably tell what they do from their names...
edit:Code:int round(float x) { int y = (int)x; if((x - y) > 0.5f) { ++y; } return y; }
Last edited by major_small; 07-12-2005 at 07:07 PM.
Join is in our Unofficial Cprog IRC channel
Server: irc.phoenixradio.org
Channel: #Tech
Team Cprog Folding@Home: Team #43476
Download it Here
Detailed Stats Here
More Detailed Stats
52 Members so far, are YOU a member?
Current team score: 1223226 (ranked 374 of 45152)
The CBoard team is doing better than 99.16% of the other teams
Top 5 Members: Xterria(518175), pianorain(118517), Bennet(64957), JaWiB(55610), alphaoide(44374)
Last Updated on: Wed, 30 Aug, 2006 @ 2:30 PM EDT
Test with some negative values too.
7. It is easier to write an incorrect program than understand a correct one.
40. There are two ways to write error-free programs; only the third one works.*
heh, I don't know. I whipped it up pretty quickly. Thanks for the input.Originally Posted by major_small
it's work fine
No it doesn't. Read Dave's post.
Quzah.
Hope is the first step on the road to disappointment.
Well I could test for a negative value and handle it accordingly but my program wont ever use the function with a negative value. If I intended to reuse this function then I would but in this situation it is useless to my program.
Code:#include <math.h>This should round -1.5 to -1, which is okay depending on what your definition of "up" is. (-1.51 rounds to -2)Code:int round(float x) { return (int) floor(x + 0.5); }
This should round -1.5 to -2, and 1.5 to 2, which is good if you have this definition of "up".Code:int round(float x) { return (int) (x - 0.5 + (x > 0.0)); }
