Thread: Can't get the loop to work

Code:

/* The Variables:
       n = the initial depth
       u = the height I can climb in 1 minute
       d = the number of feet I slip back during rest
       assume d < u and n < 100
       a value of n = 0 indicates end of input
       Each input instance should generate a single line output to 
       indicate the number of minutes it would take to climb out of the shaft.
       Sample input
       10 2 1 
       Sample output 
       17 */
       
       
#include <stdio.h>
#include <stdlib.h>

int main()
{
  
  int u,d,n,c = 0;
  int t,r,m,firsttry = t, firstrest = r, minutes = m , counter = c;
 
  printf("Enter your parameters\n",n,u,d);
  scanf("%d %d %d", &n, &u, &d);
  getchar();
  
  if (n >100 )  // If you enter a number greater then 100
  printf("You are dead dude"); // Your DEAD
  
  for (n != 0; c >= 0; c = c++)// If n is not equal to 0, then loop till it is
    {                          // c is the counter for m 
     m = c ;
     t = n - u; // t is the attempts where depth minus climb = the new heigth
     r = t + d; // r is the distance I slip back while resting 
                // where the try + the drop equals the new heigth         
                //IF I put a print statement here we get the correct answer
        {      // on the first try, so there is a problem with the loop
       //printf("%d", r); gives me 99 which is correct for the first drop 
        getchar();
         if  (r <= 0)  // So if r is equal to 0, I am out of the shaft
         printf("It took %3.0f minutes", m); // display the counter m
         else          // OR ELSE
         n = r;        // r is given the value of n for the loop
         getchar();    
         }    
     } 
  return 0;
}

The problem i am having is to get the loop and the counter to work,I can't see where the looping problem exists,, should my if statement be changed to a while or a for statement or should i abondan both and use an array?.. If i were to use an array how would i initialize it.

Too many questons , my head hurts..lol sorry, any direction on this will be welcome.

Thanks a bunch...

First off, stop making new threads for the same exact topic. Second, you never change the value of c, other than to increment it. Your loop is going to take forever, until you overflow the + signed end of your variable, and it wraps over to a negative number.


Quzah.

Also, I notice you're using a boolean expression for the initial statement in your loop.

Code:

  for (n != 0; c >= 0; c = c++)// If n is not equal to 0, then loop till it is
    {                          // c is the counter for m

You say if c is not equal to 0 in your comment, but its actually if c is greater than or equal to 0. Big difference, and that might be why the loop isn't working the way you want it to. What exactly is your logic behind those three statements? Forget the code, what should it be doing.

Or you could do like so, if that's what you meant to do.

Code:

for(; n != 0 && c >= 0; ++c)

You still have the problem of "c" looping some 2 BILLION times. On the off chance you've got an old compiler (What am I saying? EVERYONE here uses old compilers.) and have 16bit ints, your loop will still execute some 32000 times...

Quzah.

<brief derailing>

Originally Posted by linuxdude

you also don't need the c=c++ it automatically increments the value of c

In fact, shouldn't the expression c=c++ cause undefined behavior, since you're modifying c twice between sequence points?
</brief derailing>

/* The Variables:
n = the initial depth
u = the height I can climb in 1 minute
d = the number of feet I slip back during rest
assume d < u and n < 100
a value of n = 0 indicates end of input
Each input instance should generate a single line output to
indicate the number of minutes it would take to climb out of the shaft.
Sample input
10 2 1
Sample output
17 */

So, like this?

Code:

int main() {
    int n = 10, u = 2, d = 1;
    int x = 0;

    for( ; n > 0; x ++) {
        n -= u;
        u += d;
    }

    printf("%i", x);

    return 0;
}

[edit]
Of course the above code would crash if you have a negitive depth or you slip down more than you climb up;

Code:

int main() {
    int n = 10, u = 2, d = 1;
    int x = 0;

    if(n <= 0) printf("You're already out.");
    if(u <= d) printf("You'll never get out.");
    else {
        for( ; n > 0; x ++) {
            n -= u;
            u += d;
        }

        printf("It will take you %i minutes to escape.", x);
    }

    return 0;
}