Thread: A function to return a string

The blind leading the blind....

Advice from the one eyed King -

@Earth angel. - you need to make your string declaration static like so

Code:

static char string[50];

Otherwise once the functions completes, the string is no longer allocated and thus it's pointer is invalid. Sean's code is correct only because he's returning a pointer to a constant string. It won't work for variables.

Also when you enter your while loop for the first time, you're testing it before it's been initialised. Either initialise it first, or perhaps use a do..while loop.

Originally Posted by Jez

Code:

static char string[50];

Otherwise once the functions completes, the string is no longer allocated and thus it's pointer is invalid. Sean's code is correct only because he's returning a pointer to a constant string. It won't work for variables.

I know I can't return a pointer to a local variable, but having a sting[50] constant doesn't help. Or at least I don't know how to make it helpful. I can't return a string. .....Unless I'm not understanding your advice correctly.