switch/case - Just wondering

**Snip** · 05-21-2005

I was just wondering wether there are any reasons why I shouldn't do something like this:

Code:

void func(int p) {
  switch(p) {
    case 1: {
      int i;
      /* Do something with i */
    } break;

    case 2: {
      char msg[10];
      /* Do something with msg */
    } break;
  }
}

instead of

Code:

void func(int p) {
  int i;
  char msg[10];

  switch(p) {
    case 1:
      /* Do something with i */
      break;
    case 2:
      /* Do something with msg */
      break;
  }
}

So basicly, is it alright to place brackets in every case and then declare variables in it? Because I'm learning the win32 API at the moment and I don't like it when I have to declare all of my variables at the top of the WndProc function, especially with big programs it's annoying...

**Krak** · 05-21-2005

Originally Posted by Snip

I was just wondering wether there are any reasons why I shouldn't do something like this:

Code:

void func(int p) {
  switch(p) {
    case 1: {
      int i;
      /* Do something with i */
    } break;

    case 2: {
      char msg[10];
      /* Do something with msg */
    } break;
  }
}

instead of

Code:

void func(int p) {
  int i;
  char msg[10];

  switch(p) {
    case 1:
      /* Do something with i */
      break;
    case 2:
      /* Do something with msg */
      break;
  }
}

So basicly, is it alright to place brackets in every case and then declare variables in it? Because I'm learning the win32 API at the moment and I don't like it when I have to declare all of my variables at the top of the WndProc function, especially with big programs it's annoying...

The first one only creates the variables if the case is met, which saves you from creating them if you don't need them.

**quzah** · 05-22-2005

There's a problem with declaring your variables in a case statement. I believe Salem has discussed it here before. I can't quite remember what it was, or actually who all was discussing it. Well, aside from the fact that the variable's scope only exists for that case block.

Quzah.

**Salem** · 05-22-2005

Code:

void func(int p) {
  switch(p) {
    case 1: {
      int i;
      /* Do something with i */
    } break;

    case 2: {
      char msg[10];
      /* Do something with msg */
    } break;
  }
}

This is fine - the scope of the variables is limited by the braces.
Though for the reasons you state, you should consider making each case a separate function to keep the body of the switch nice and simple. One recently memorable (for the wrong reasons) switch was way over 3000 lines long.

The problem Quzah is thinking of is this

Code:

void func(int p) {
  switch(p) {
    int badvar = 0;
    case 1: {
      int i;
      /* Do something with i */
    } break;

    case 2: {
      char msg[10];
      /* Do something with msg */
    } break;
  }
}

The problem is, despite what it looks like, badvar will never be initialised (cases are labels, and the switch is an organised goto). But the variable will still exist non the less.

gcc for example reports
warning: unreachable code at beginning of switch statement

Thread: switch/case - Just wondering

Thread Tools

Search Thread

Display

switch/case - Just wondering

Similar Threads

Wondering if this would be a dangerous use of globals.

Alternative to switch/case?

wondering about people here

Just wondering.

Just wondering