incompatible pointer type

[krappa]

I am trying to parse the information in a TIFF file. To do this, I have an array of unsigned bytes.

FILE * tiffFile;
int i,j;
GLubyte (* fields)[12];
unsigned short numOfFields=0;
long index;

...
//get number of fields
...

fields = malloc(numOfFields*12*sizeof(GLubyte));

for(i=0;i<numOfFields;i++) {
	for(j=0;j<12;j++) {
		fread(&(fields[i][j]),1,1,tiffFile);
	}
}

index = findTag(0x100,fields,numOfFields);

The findTag function is as follows.

long findTag(short tag, GLubyte **fields, int numOfFields){
	int i,found=0;
	for(i=0;(i<numOfFields) && !found;i++){
		if (tag == fields[i][0]*256 + fields[i][1])
			found = 1;
	}
	printf("Index of tag: %x is: %d",tag,i);
	return i;
}

For a reason I do not understand, I get a warning "passing arg 2 of 'findTag' from incompatible pointer type". And while executing the findTag function, I get a Bus Error, usually (but not always) when i=1.
I checked in the debugger, fields in the main function, or in findTag points to the same memory address. And I don't understand why it works perfectly when I fill it up in the main, but not when I want to read from it in findTag.
I tried to use a fixed size for the array, but I get the exact same problem.

[quzah]

1) This is not a pointer to a pointer:

GLubyte (* fields)[12];

2) This is:

long findTag(short tag, GLubyte **fields, int numOfFields){

Quzah.

[krappa]

Understood. Though I always thought arrays were handled as pointers. Anyway, what type do I declare as argument 2 of findTag ? Or any other way of passing my arrays to findTag.

[itsme86]

You should be okay if you just drop the parentheses around the fields declaration. GLubyte (* fields)[12] is not the same as GLubyte *fields[12]. In the latter, the * is associated with the GLubyte instead of fields.

[krappa]

This is the way I want it to be : a GLubyte *fields[12] does not work in this case (segfault while filling it up).

For the sake of facilitating the example, suppose I declare :

GLubyte fields[65536][12]

I still get "passing arg 2 of 'findTag' from incompatible pointer type". If I want to pass this double array to my function, how do I declare it ?

[quzah]

This is the way I want it to be : a GLubyte *fields[12] does not work in this case (segfault while filling it up).

Do you actually allocate any space for all of those pointers, or are you just trying to use them all uninitialized?

Quzah.

[krappa]

I initialize it right here :

//get number of fields
...
fields = malloc(numOfFields*12*sizeof(GLubyte));

I've excluded the details of getting numOfFields, but it works, I've checked in the debugger.

[quzah]

Well that's part of your problem. You're doing it wrong.

fields = malloc( sizeof( GLubyte * ) * 12 );
for( x = 0; x < 12; x++ )
    fields[ x ] = malloc( sizeof( thisdataelement ) * lengthofthisarrayrow );

When you're done, you have to free it in the reverse:

for( x = 0; x < 12; x++ )
    free( fields[ x ] );
free( x );

Quzah.

[krappa]

Perhaps I wasn't very clear, but you didn't exactly understand what I wanted.
Anyway, I solved the problem by just declaring arg 2 of findTag as

long findTag(short tag, GLubyte (* fields)[12], int numOfFields)

I just thought I could make it work without putting the exact same type and thus, not forcing the array size.

Thanks for the help, anyway, guys.

[Salem]

> GLubyte (* fields)[12];
> fields = malloc(numOfFields*12*sizeof(GLubyte));
Of course, you should be doing this.
fields = malloc ( numOfFields * sizeof *fields );

See http://faq.cprogramming.com/cgi-bin/...&id=1043284351

Which coupled with
long findTag(short tag, GLubyte (* fields)[12], int numOfFields)
Is just fine.

Indeed, you could go on to say
GLubyte foobar[100][12]; // major size doesn't matter, so long as minor size is 12
And then call your function with
findTag(0, foobar, 100);