String Search

[vice]

I'm trying to make a search string function, it will search a string if it's found it will return 1 or 0 if it's not found.

#include <stdio.h>
#include <string.h>

/*
	A program for searching a string
*/
int stringSearch(char **str, char *key, int *position, int size);
int main()
{
	char *str[5] ={"World", "Hello", "arcs", "Sober", "Fun"};
	char *key;
	int pos;
	printf("Input the keyword:\n");
	scanf("%s", key);

	if(stringSearch(str, key, &pos,5))
	{
	printf("Found in element: %d of the array\n", pos);
	}
	else
	{
	printf("Not Found\n");
	}
	return 0;
}

int stringSearch(char *str[], char *key, int *position, int size)
{
	int pos;
	for (pos=0;pos<size ;pos++)
	if (strcmp(str[pos],key)==0 )
	{
		*position = pos;
		return 1;
	}
	return 0;
}

But the problem is the code always return 0, no matter what the input is. Anyone can help me?

[quzah]

char *key;
int pos;
printf("Input the keyword:\n");
scanf("%s", key);

Where exactly are you scaning into? In other words, what memory does key point to?

Quzah.

[0rion]

As Quzah said, key is simply a pointer to a character that doesn't really point to anywhere. Since it doesn't point to anything - what you are trying to do is read in a string into a character pointer which results in a seg fault usually. You have 2 alternatives, 1 is to point key to a string literal like "Hello":

char* key = "Hello";

You obviously don't want this since you have no room for user input then, the other alternative is to declare an array of characters or malloc() a size of memory for key.

char key[BUFSIZ];

char* key = malloc(BUFSIZ);
if (key == NULL)
{
        fprintf(stderr,"Error allocating memory\n");
        exit (1);
}

[vice]

thanks for the solution, that really help me alot