Thread: please help

Thanks man. I get the following errors:
ass.c: In function `open_batch':
ass.c:112: warning: assignment makes pointer from integer without a cast

Code:

void open_batch()
{
   FILE *fp;
   char f[100];
   char c;
   int a = 0, b = 0;
   int d, e, g, h, i, j, k, l;
   printf("Please enter the file you wish to run: ");
   scanf("%s", &f);
   if((fp = fopen(f,"rt") == NULL))    //ERROR IS HERE
   {
      printf("No such file");
   }

   while(fp = fopen(f,"rt") == NULL)   //ERROR ALSO HERE
   {
      c = fgetc(file);
      if((c == 70) || (c == 102) || (c == 85) || (c == 117))
      {

It's simply a warning but it would help if you showed which line the warning was on since I dunnoe which line is line 112

Code:

   while(fp = fopen(f,"rt") == NULL)

Should be:

Code:

   while((fp = fopen(f,"rt")) == NULL)

Just watch where you are "bracing" your statements.
Also the first while loop:

Code:

 if((fp = fopen(f,"rt") == NULL))

Should be:

Code:

 if((fp = fopen(f,"rt")) == NULL)

On a side note,

Code:

c = fgetc(file);

Unless you have another FILE* called file, this won't work. Use fp instead of file to read from what you opened in the if/while statements. Also why are you opening the file for reading twice?

http://cboard.cprogramming.com/showthread.php?t=63798
Try and keep to one thread for one question in future.

you opened the file in the if statement. this should not be done becaus the null point assignment takes place only in the next line of comparision. you will be clear after you see my code below. trust me it works!

Code:

#include<stdio.h>
#include<conio.h>

void main()
{
   FILE *fp;
   char f[100];
   char c;
   int a = 0, b = 0;
   int d, e, g, h, i, j, k, l;
   printf("Please enter the file you wish to run: ");
   scanf("%s", &f);
   fp=fopen(f,"rt");              
   if(fp== NULL)    //NO MORE ERROR          
   {
      printf("No such file");
   }

   while(!feof(fp))   //NO MORE ERROR HERE
   {
      c = fgetc(fp);
      if((c == 70) || (c == 102) || (c == 85) || (c == 117))
      {
		  printf("really");
	  }
	
   }
  
}

ALSO C=FGETC(FP), YOU GAVE FGETC(FILE). careful there

Originally Posted by coolshyam

you opened the file in the if statement. this should not be done

You know what really shouldn't be done?

Code:

void main()
{

Read the FAQ, "dear".

Oh, while you're at it, read the one on why you don't control loops with feof.

Quzah.

> shuoldn't the scanf part read
Yes it should read f (not &f)
Though in this particular case, since f is an array, the result is the same.

But it would be very wrong all of a sudden if f became a pointer.