Thread: Newbie

hey guys I need some help, I think something wrong with the if statement in main, I can't get it right. please can someone tell me what I am doing wrong. Thanks

Code:

#include <stdio.h>
#include <time.h>
#include <stdlib.h>
typedef enum {Spades, Hearts, Diamonds, Clubs} Suit ;

typedef struct 
{
  Suit suit ;
  int  facevalue;
}card ;

typedef struct
{
  char name[80];
  card card1;
  card card2;
  int score;
}player;

void deal(player* p);
void calculate(player* p);
void displayCard(const card* c, int count);
void displayPlayerCard(const player* p);           

int main(void)
{
   /*initialize player1 and player2 */
   player player1 = {"Joe Smith", {5,Spades}, {5,Hearts},0};
   player player2 = {"David Jones", {9,Clubs}, {9, Diamonds}, 0};
  
    srand(time(0));

   /* Player 1 */

   deal(&player1);
   calculate(&player1);
   printf("Player 1 :%s \n", player1.name);
   displayPlayerCard(&player1);
   printf("Total score is %d.\n\n", player1.score);

/* Player 2 */
   deal(&player2);
   calculate(&player2);
   printf("Player 2 :%s \n", player2.name);
   displayPlayerCard(&player2);
   printf("Total score is %d.\n\n", player2.score);
   return 0;

if (player1.score > player2.score)

{
printf("%s is the winner\n", player1.name);

else if (player1.score < player2.score)

printf("%s is the winner\n", player2.name);

else printf("Game tied\n") 

}
}


void deal(player* p)
{
  (*p).card1.facevalue = rand()% 13 + 1;
  (*p).card1.suit = rand( ) % 4  ;

   (*p).card2.facevalue = rand()%13 +1;
   p->card2.suit = rand( ) % 4  ;
}



void calculate(player* p)
{
 p->score = p->card1.facevalue + p->card2.facevalue;
}

void displayPlayerCard(const player* p)
{ 
   displayCard(&(p->card1), 1);
   displayCard(&(p->card2), 2);
}

void displayCard(const card* c, int count)
{
  int number = c->facevalue;
  int suit = c->suit;
  printf("Card %d: ", count);

  switch(number) 
  {
    case 1 : printf("Ace"); break;
    case 11 : printf("Jack"); break;
    case 12: printf("Queen"); break;
    case 13 : printf("King"); break;
    default: printf("%d", number);
  }

  switch(suit)
  {
    case 0 : printf(" of Spades\n"); break;
    case 1 : printf(" of Hearts\n"); break;
    case 2 : printf(" of Diamonds\n"); break;
    case 3 : printf(" of Clubs\n"); break;
  }
}

Tell us what you want it to do and what it is doing. At first glance it would appear that you're doing something funky with your braces.
edit: And I can't find where main() is returning anything.

Originally Posted by jat421

the player with maximum total points win the game and the if() satement is there is do that. Acutally once I get the if statement right I will write it as a different function.

Thanks

What's up with this?

Code:

   return 0;

if (player1.score > player2.score)

Is this the "if" statement that you are talking about?


Well, remove the return, and you have this:

Code:

if (player1.score > player2.score)

{
printf("%s is the winner\n", player1.name);

else if (player1.score < player2.score)

printf("%s is the winner\n", player2.name);

else printf("Game tied\n") 

}

Misplaced "else", and missing semicolon (the semicolon is easy; let's fix the "else"):

In general, you can have something like this for your if statements:

Code:

  if (Something) {
    /* do something */
  }
  else if (SomethingElse) {
   /* do something else */
  }
  else {
    /* do whatever is appropriate if the first two failed */
  }

  return 0;

Try it. (I recommend using the braces {} even if you don't need them, but that's just me.)

Regards,

Dave

Thanks that worked , lol what a stupid mistake...I think I need some cofffe

It shouldn't be easy to make a mistake like this. Everything looks like it is indented fine except for that if/else if structure and that is probably why you lost track of your braces etc.