Simple Sort Question

[krack_kills]

I'm attempting to sort a pointer array using a bubbleSort (yes I know how inefficient it is but for the purpose of this program it'll work just fine) and I'm having trouble getting the sort to iterate through my pointer array. This program requires that no array notation be used i.e. '[ ]' brackets, just pointer arithmetic. The user also defines the size of the pointer array with a command line argument ( 'a.out 5' where 5 would be the array size). I believe the problem in my sort lies in the if() statement but I'm unsure on how to fix it. Can anyone help?

The program's fairly unrefined at this point so sorry for the mess:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>



void bubbleSort(int *p, int array_size);

int main(int argc, char **argv)
{

    int i, j, q;
	int *p, *b;
	++argv;
	q=atoi(*argv);
	

	p= calloc(q, sizeof(int));
	b=p;
	
	srand( (unsigned)time( NULL ) );
	
	if (q>0){
	printf("Unsorted:\n");
    	for (i = 0; i < q; i++) {
        	*b = (rand()%100);
        	printf("%d\n",*b);
			b++;
    		}
	}
	else {
		printf("Invalid Entry\n");
		return 0;
	}
	
	bubbleSort(b, q);
	
	for (i = 0; i < q; i++)
	{
    		printf("%i\n", *p);
	}
	

	free(b);
}


void bubbleSort(int *p, int array_size)
{
  int i, j, temp;

  for (i = (array_size - 1); i >= 0; i--)
  {
    for (j = 1; j <= i; j++)
    {
      if (*p-- > *p)
      {
        temp = *p--;
        *p-- = *p;
        *p = temp;
      }
    }
  }
}

[hk_mp5kpdw]

void bubbleSort(int *p, int array_size)
{
  int i, j, temp;

  for (i = (array_size - 1); i > 0; i--)
  {
    for (j = 0; j < i; j++)
    {
      if (*(p+j) > *(p+j+1))
      {
        temp = *(p+j);
        *(p+j) = *(p+j+1);
        *(p+j+1) = temp;
      }
    }
  }
}

[pianorain]

	int i, j, q;
	int *p, *b;

It might help if you used some slightly more descriptive names. It can get rather tedious trying to tell apart all those p's,q's, and b's.

	++argv;
	q=atoi(*argv);

This just looks like a bad idea. What if there isn't an argument? And why increment argv? Try something like this:

	if(argc < 2)
		return 1;
	q=atoi(*(argv+1));

	for (i = 0; i < q; i++)
	{
    		printf("%i\n", *p);
	}

I bet this doesn't work like you're hoping. Hint: make the same change that hk_mp5kpdw did to your bubbleSort.

[krack_kills]

I think that the changes hk suggested work, however, when I attempt to print out the sorted array it still only displays the first value of the array. For example

camaro$ a.out 5
Unsorted:
12
58
8
1
90
12
12
12
12
12

where the last 5 digits are where the array is supposed to print sorted.

[hk_mp5kpdw]

for (i = 0; i < q; i++)
{
    printf("%i\n", *(p+i));
}

[ssharish]

hope this code helps a bit

void bubblesort(int *p, int array_size)
{
int i, j, temp;
    
    for(i=0;i<10-1;i++)
    {
            for(j=i+1;j<10;j++)
            {
                        if(*(p+i) > *(p+j))
                        {
                            temp=*(p+i);
                            *(p+i)=*(p+j);
                            *(p+j)=temp;
                    }
         }
}    
                 
}

[krack_kills]

Through some slight Divine intervention (a.k.a my astute girlfriend) and the help of you guys, it works.

Thanks
Peace.