Thread: why core dump in this function?

I have been searching through various sources, searched through the posts here, and I cannot figure it out why this function is segfaulting on me.

Code:

#include <stdio.h>
#include <stdlib.h> 
#include <string.h>

#define SIZE 41


void read_message(char[]);

int main()
{
   char message[SIZE];    

   read_message(message);

  return 0;
}


void read_message(char array[])
{
    
    int ch;
    int i = 0; 
    
    printf("Enter your message:\n"); 
    
    while ( (ch=getchar()) != '\n' ) 
    {
        array[i] = ch;
        i++;
    } 
    
    array[i] = '\0';        
}

I mean when I execute, it asks for the message, and right after I enter it, the program crashes. I'm pretty sure it does not go past "while". It's so frustrating to be stuck on something so simple as reading an array of chars...
Thanks in advance.

Allright, I went though it again, cleaned it all up, and it looks for now as this part is working! Thanks and sorry that I bothered you.

The first thing I notice is that you're trying to pass an array as a parameter. In C, you can not do this. Instead, pass a pointer to the first element of the array. You'll have to change some of your arithmetic to work with a pointer instead of directly interfacing with an array. Since this shouldn't have even been legal, what compiler are you using?

while ( (ch=getchar()) != '\n' )

That's some ugly code! (no offense) Try splitting that up into two statements and joining them in the loop with a logical AND.

Is it really wrong? It looks almost like the function to read a line from my textbook, which is KN King.
What I noticed after a couple of more hours of working on this, is that my problem with core dump lies in the loop of the next function. I inserted a control printf statement inside my loop, and ran the program (it compiles using gcc, but not DevC++). It displayed my printf about a hundered something of times and then core was dumped. Can you take a look? (I'm not supposed to use pointers here... only array subscripting)

Code:

int clean_array(char array[], char clean[], int size)
{
    int i, j = 0;

    for(i = 0; i < size; i++)
    {
        while(array[i] != '\0')          /* read original array */
        {   
            if( isalpha(array[i]) )
            {
                clean[j] = array[i];  /* insert characters in clean array */
                j++;                         /* move to next cell if char found */
            }                      
        }
    }

    clean[j] = '\0';                    /* close clean_array string */


    return (j-1);                       /* return number of characters*/
}

Thanks, so I tried to process the array within the array. Hm....