loop-exit problem

**duvernais28** · 02-01-2005

I have a problem with a loop refusing to stop at the end of file.
Here's the code.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <string.h>

#define CHRS 41
#define RANKSIZ 10

void main(void)
{
   FILE *rslpf;                       /* Pointer to file description */
   long B_dd, B_mm, B_yyyy, En_dd, En_mm, En_yyyy, result;   
   char rank[RANKSIZ], stations[CHRS], gender, FulName[30] ;

   if ((rslpf = fopen("C:\\rslpf.txt", "r")) == NULL)
   {  printf("Cannot open file\n");
      exit(EXIT_FAILURE);
   }
   while (fscanf(rslpf, "%i%*c %[^/]%*c  %[^/]%*c  %c%*c %i%*c  %i%*c  %i%*c %i%*c  %i%*c  %i%*c  %[^\n]%*c ",
          &result, rank, FulName, &gender, &B_dd, &B_mm, &B_yyyy, &En_dd, &En_mm, &En_yyyy, stations) != EOF)
   {
            printf("Officer: \nGender: \nDate of Birth: \nDate of Enlistment: \nDepartment: ");
            gotoxy(22,1);
            printf("%s %i %s", rank, result, FulName);
            gotoxy(22,2);
            printf("%c", gender);
            gotoxy(22,3);
            printf("%i/%i/%i", B_dd, B_mm, B_yyyy);
            gotoxy(22,4);
            printf("%i/%i/%i", En_dd, En_mm, En_yyyy);
            gotoxy(22,5);
            printf("%s", stations);
            getchar();
            clrscr();
    }
   fclose(rslpf);   
}

I'd appreciate your help...

**Hammer** · 02-01-2005

Code:

while (fscanf(rslpf, "%i%*c %[^/]%*c  %[^/]%*c  %c%*c %i%*c  %i%*c  %i%*c %i%*c  %i%*c  %i%*c  %[^\n]%*c ",
          &result, rank, FulName, &gender, &B_dd, &B_mm, &B_yyyy, &En_dd, &En_mm, &En_yyyy, stations) != EOF)

That is pretty horrid. You'll probably find that you're not reading in correctly, and the program is stuck in a loop well before EOF. You'd do better by using fgets(), then sscanf(), at least that way you spot problems easier.

**duvernais28** · 02-01-2005

I suspect my end-of-file indicatior may not be set. Everything in the file is read and displayed. The loop just doesn't end.
The data was entered into the file using multiple functions bcos I had to validate each one. And a '/' was placed between them at the time they were written. Is there any way that I could set the end of file indicator before hand (immediately after the final field has been input)?

**quzah** · 02-01-2005

EOF doesn't get "not set". To prove it, do this:

Code:

int foo;
if ((rslpf = fopen("C:\\rslpf.txt", "r")) == NULL)
   {  printf("Cannot open file\n");
      exit(EXIT_FAILURE);
   }
   while ( (foo = fgetc( rslpf )) != EOF )
        printf("%c %d\n", foo, foo );

This will prove that Hammer's correct, and you're not.

Oh, and main is not a void function. It returns an int. Always.

Quzah.

**duvernais28** · 02-01-2005

Absolutely right quzah. Thanks alot.

Thread: loop-exit problem

Thread Tools

Search Thread

Display

loop-exit problem

Similar Threads

Problem with a loop

why it can not exit the while loop

whats the problem....

having problem with string statement during a loop!

While loop problem