Thread: while loop problem

i made this program to print the fibnacci series. everything gone okey. but the variable m i used in this program, when i printed it's value in the end i get very unwanted result.

#include<stdio.h>
#include<conio.h>
void main()
{
int n,f=0,s=1,t,m=2;
clrscr();
printf("This program will print fibnacci series\n");
printf("How many Number to be printed in the series?\n");
scanf("%d",&n);
printf("0 1");

do
{
t=f+s;
printf(" %d",t);
f=s;
s=t;
m++;
}

while(m<=n);
printf("%d",m)

getch();
}


this was the output-

This program will print fibnacci series
How many Number to be printed in the series?
5
0 1 1 2 3 56

is 56 not unobvious?
i think it shoul give me 6

before we get to your problem, main() returns and int

Code:

int main(void)
{
    return 0;
}

Try not to use non standard headers like conio.h
replace getch() with getchar() (from stdio.h)
clrscr() would need to be taken out of the program completely

okey........for all but nowhere was the solution!

Here is your code with the already suggested fixes.

Code:

#include<stdio.h>
int main()
{
	int n,f=0,s=1,t,m=2;
	printf("This program will print fibnacci series\n");
	printf("How many Number to be printed in the series?\n");
	scanf("%d",&n);
	printf("0 1");
	do
	{
		t=f+s;
		printf(" %d",t);
		f=s;
		s=t;
		m++;
	}
	while(m<=n); 
	printf("%d",m)
	getchar();
}

The output should not give you 6, the next number should be 8. The whole series up to 100 is 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89.

I don't see an immediate problem without digging too deep into your logic (which no one likes to do when nothing is commented). I imagine the problem is coming from somewhere in your do, while loop. This is a common program for beginners to write, so do a board search for 'fibonacci', and see if your logic statements differ from what others have used.

edit: Blast... beaten again... Or you could just follow Prelude's suggestion.

thanks very much all the ppl.
it was the same problem.......it was 5 and 6, not 56.

i am totally a newbie to c language, it has hardly been 10 days, i started learning c language.

thanks again

let me quote something prelude said to me a long while ago

Originally Posted by Prelude

>so what is an alternative to system("cls") ?
There isn't a good solution to the clearing-the-screen problem. I usually recommend that you either think long and hard about why you want to clear the screen, or isolate the non-portable parts:

Code:

void
clear_screen(void)
{
  system("cls");
}

By only using clear_screen to clear the screen, you only have to make minor changes when porting the program. It won't run everywhere unchanged, but when it comes to useful and nontrivial programs, you have to loosen your definition of "portable" a bit.

You can find various ways to clear the screen in the FAQ.

sorry for i am replying after a long time:

point 1)
I couldn't understand why people are saying to remove the clrscr() function from my program.

point 2)
My teacher told me to use getch() function in the end to stop the screen when viewing the output, if we don't do that the output screen stops for a sec only.

so is getch()
to stop the console from closing, getch() can be replace with getchar()